Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 744103002: telemetry: fix start_with_url benchmark. (Closed)

Created:
6 years, 1 month ago by ernstm
Modified:
6 years, 1 month ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, rnephew (Reviews Here)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

telemetry: fix start_with_url benchmark. This benchmark was broken when command line args got removed from measurements. NOTRY=True TBR=tonyg@chromium.org BUG=435108 Committed: https://crrev.com/dfe2f5502b027d85942666d502cc9f0f95361641 Cr-Commit-Position: refs/heads/master@{#305032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M tools/perf/benchmarks/start_with_url.py View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ernstm
PTAL
6 years, 1 month ago (2014-11-20 17:49:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744103002/1
6 years, 1 month ago (2014-11-20 17:50:53 UTC) #3
dtu
rubberstamp lgtm
6 years, 1 month ago (2014-11-20 17:51:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 17:51:55 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:52:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfe2f5502b027d85942666d502cc9f0f95361641
Cr-Commit-Position: refs/heads/master@{#305032}

Powered by Google App Engine
This is Rietveld 408576698