Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: tools/perf/benchmarks/start_with_url.py

Issue 744103002: telemetry: fix start_with_url benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/start_with_url.py
diff --git a/tools/perf/benchmarks/start_with_url.py b/tools/perf/benchmarks/start_with_url.py
index f9c199b6a4f80f7693929a2f746de1aaff1df206..895dd9116c37f4ee3bea907fe4a9820ca628cd8c 100644
--- a/tools/perf/benchmarks/start_with_url.py
+++ b/tools/perf/benchmarks/start_with_url.py
@@ -7,21 +7,26 @@ import page_sets
from telemetry import benchmark
+class _StartWithUrl(benchmark.Benchmark):
+ page_set = page_sets.StartupPagesPageSet
+ test = startup.StartWithUrl
+
+ def CreatePageTest(self, options):
+ is_cold = (self.tag == 'cold')
+ return self.test(cold=is_cold)
+
+
@benchmark.Enabled('has tabs')
@benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
-class StartWithUrlCold(benchmark.Benchmark):
+class StartWithUrlCold(_StartWithUrl):
"""Measure time to start Chrome cold with startup URLs"""
tag = 'cold'
- test = startup.StartWithUrl(cold=True)
- page_set = page_sets.StartupPagesPageSet
options = {'pageset_repeat': 5}
@benchmark.Enabled('has tabs')
@benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
-class StartWithUrlWarm(benchmark.Benchmark):
+class StartWithUrlWarm(_StartWithUrl):
"""Measure time to start Chrome warm with startup URLs"""
tag = 'warm'
- test = startup.StartWithUrl(cold=False)
- page_set = page_sets.StartupPagesPageSet
options = {'pageset_repeat': 10}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698