Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 743943002: Fixes crash in media::AudioBlockFifo::Push for Apple Thundebolt Displays (Closed)

Created:
6 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, no longer working on chromium, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes crash in media::AudioBlockFifo::Push for Apple Thundebolt Displays BUG=434681 TEST=WebRTC demos while adding/removing Thunderbolt cable during an ongoing audio session Committed: https://crrev.com/622f7624b682917bff90db249d0eb452443b73b4 Cr-Commit-Position: refs/heads/master@{#305004}

Patch Set 1 #

Patch Set 2 : Improved comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 3 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
henrika (OOO until Aug 14)
Tommi, please find a solution to the crash as discussed in the issue. I have ...
6 years, 1 month ago (2014-11-20 09:58:21 UTC) #2
henrika (OOO until Aug 14)
Done multiple tests using Apple Thunderbolt Display and can confirm that the FIFO is dynamically ...
6 years, 1 month ago (2014-11-20 10:07:48 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-11-20 10:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743943002/20001
6 years, 1 month ago (2014-11-20 12:07:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 12:54:16 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 12:54:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/622f7624b682917bff90db249d0eb452443b73b4
Cr-Commit-Position: refs/heads/master@{#305004}

Powered by Google App Engine
This is Rietveld 408576698