Store binary flags in bool instead of int in WebInputEvent

Store binary flags in bool instead of int in WebInputEvent

Avoiding unnecessary size increase and improve readability by using the more
appropriate type. The comments in the code justifying the use of int type are
incorrect. In particular, these types are always initialized via the ctor that
does a memset on the sizeof, so padding DOES get initialized and shouldn't be
reported by valgrind as uninitialized memory.



 
BUG=435608
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186343

[majidvp, 2014-11-26 20:35:34]

majidvp@chromium.org changed reviewers:
+ jdduke@chromium.org

[Rick Byers, 2014-11-26 22:17:38]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2014-11-26 22:17:39]

lgtm, thanks!

[Rick Byers, 2014-11-26 22:20:12]

On 2014/11/26 22:17:39, Rick Byers wrote:
> lgtm, thanks!

It's probably worth mentioning in the CL description that we believe the
comments in the code saying this was necessary are incorrect.  In particular,
these types are always initialized via the ctor that does a memset on the
sizeof, so padding DOES get initialized and shouldn't be reported by valgrind as
uninitialized memory.  You mentioned that you did some manual testing (now that
we don't have valgrind try bots) and weren't able to provoke any failures.  I
say we try it and see if any issues crop up (we can always back it out).

[Rick Byers, 2014-11-26 22:20:58]

rbyers@chromium.org changed reviewers:
+ aelias@chromium.org
- jdduke@chromium.org

[Rick Byers, 2014-11-26 22:23:14]

rbyers@chromium.org changed reviewers:
+ jochen@chromium.org
- aelias@chromium.org

[Rick Byers, 2014-11-26 22:23:14]

+jochen for a random non-US OWNER in Source/web

[jochen (gone - plz use gerrit), 2014-11-27 14:58:13]

lgtm

[majidvp, 2014-11-28 15:53:35]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2014-11-28 15:54:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/743883005/20001

[commit-bot: I haz the power, 2014-11-28 16:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-28 16:42:56]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/92343)

[majidvp, 2014-12-02 21:48:25]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2014-12-02 21:49:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/743883005/20001

[commit-bot: I haz the power, 2014-12-02 22:53:34]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186343