Store binary flags in bool instead of int in WebInputEvent

public/web/WebInputEvent.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 225 matching lines @@
     // The actual key code genenerated by the platform.  The DOM spec runs
     // on Windows-equivalent codes (thus |windowsKeyCode| above) but it
     // doesn't hurt to have this one around.
     int nativeKeyCode;
 
     // This identifies whether this event was tagged by the system as being
     // a "system key" event (see
     // http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx for
     // details). Other platforms don't have this concept, but it's just
     // easier to leave it always false than ifdef.
-    // See comment at the top of the file for why an int is used here.
     bool isSystemKey;
 
     // |text| is the text generated by this keystroke.  |unmodifiedText| is
     // |text|, but unmodified by an concurrently-held modifiers (except
     // shift).  This is useful for working out shortcut keys.  Linux and
     // Windows guarantee one character per event.  The Mac does not, but in
     // reality that's all it ever gives.  We're generous, and cap it a bit
     // longer.
     WebUChar text[textLengthCap];
     WebUChar unmodifiedText[textLengthCap];
@@ skipping 89 matching lines @@
     };
 
     float deltaX;
     float deltaY;
     float wheelTicksX;
     float wheelTicksY;
 
     float accelerationRatioX;
     float accelerationRatioY;
 
-    // See comment at the top of the file for why an int is used here.
-    int scrollByPage;
-
-    // See comment at the top of the file for why an int is used here.
-    int hasPreciseScrollingDeltas;
     Phase phase;
     Phase momentumPhase;
 
-    // See comment at the top of the file for why an int is used here.
     // Rubberbanding is an OSX visual effect. When a user scrolls the content
     // area with a track pad, and the content area is already at its limit in
     // the direction being scrolled, the entire content area is allowed to
     // scroll slightly off screen, revealing a grey background. When the user
     // lets go, the content area snaps back into place. Blink is responsible
     // for this rubberbanding effect, but the embedder may wish to disable
     // rubber banding in the left or right direction, if the scroll should have
     // an alternate effect. The common case is that a scroll in the left or
     // right directions causes a back or forwards navigation, respectively.
     //
     // These flags prevent rubber banding from starting in a given direction,
     // but have no effect on an ongoing rubber banding. A rubber banding that
     // started in the vertical direction is allowed to continue in the right
     // direction, even if canRubberbandRight is 0.
-    int canRubberbandLeft;
-    int canRubberbandRight;
+    bool canRubberbandLeft;
+    bool canRubberbandRight;
+
+    bool scrollByPage;
+    bool hasPreciseScrollingDeltas;
 
     WebMouseWheelEvent()
         : WebMouseEvent(sizeof(WebMouseWheelEvent))
         , deltaX(0.0f)
         , deltaY(0.0f)
         , wheelTicksX(0.0f)
         , wheelTicksY(0.0f)
         , accelerationRatioX(1.0f)
         , accelerationRatioY(1.0f)
-        , scrollByPage(false)
-        , hasPreciseScrollingDeltas(false)
         , phase(PhaseNone)
         , momentumPhase(PhaseNone)
         , canRubberbandLeft(true)
         , canRubberbandRight(true)
+        , scrollByPage(false)
+        , hasPreciseScrollingDeltas(false)
     {
     }
 };
 
 // WebGestureEvent --------------------------------------------------------------
 
 class WebGestureEvent : public WebInputEvent {
 public:
     int x;
     int y;
@@ skipping 35 matching lines @@
             // May be redundant with deltaX/deltaY in the first scrollUpdate.
             float deltaXHint;
             float deltaYHint;
         } scrollBegin;
 
         struct {
             float deltaX;
             float deltaY;
             float velocityX;
             float velocityY;
-
-            // TODO: Use a bitfield instead of two ints for these flags
-
             // Whether any previous GestureScrollUpdate in the current scroll
             // sequence was suppressed (e.g., the causal touchmove was
             // preventDefault'ed). This bit is particularly useful for
             // determining whether the observed scroll update sequence captures
             // the entirety of the generative motion.
-            // See comment at the top for why an int is used here instead of a bool.
-            int previousUpdateInSequencePrevented;
-            // See comment at the top of the file for why an int is used here
-            // instead of a bool.
-            int preventPropagation;
+            bool previousUpdateInSequencePrevented;
+            bool preventPropagation;
         } scrollUpdate;
 
         struct {
             float velocityX;
             float velocityY;
         } flingStart;
 
         struct {
             float scale;
         } pinchUpdate;
@@ skipping 17 matching lines @@
     // Maximum number of simultaneous touches supported on
     // Ash/Aura.
     enum { touchesLengthCap = 16 };
 
     unsigned touchesLength;
     // List of all touches, regardless of state.
     WebTouchPoint touches[touchesLengthCap];
 
     // Whether the event can be canceled (with preventDefault). If true then the browser
     // must wait for an ACK for this event. If false then no ACK IPC is expected.
-    // See comment at the top for why an int is used here instead of a bool.
-    int cancelable;
+    bool cancelable;
 
     // Whether the event will produce scroll-inducing events if uncanceled. This
     // will be true for touchmove events after the platform slop region has been
     // exceeded and fling-generating touchend events. Note that this doesn't
     // necessarily mean content will scroll, only that scroll events will be
     // generated.
-    // See comment at the top for why an int is used here instead of a bool.
-    int causesScrollingIfUncanceled;
+    bool causesScrollingIfUncanceled;
 
     WebTouchEvent()
         : WebInputEvent(sizeof(WebTouchEvent))
         , touchesLength(0)
         , cancelable(true)
         , causesScrollingIfUncanceled(false)
     {
     }
 };
 
 #pragma pack(pop)
 
 } // namespace blink
 
 #endif