content/browser/frame_host/navigation_controller_delegate.h - Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: charlie's fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_delegate.h

diff --git a/content/browser/frame_host/navigation_controller_delegate.h b/content/browser/frame_host/navigation_controller_delegate.h

index 52567ef3c621976907e5b008fa7c3e2a8cc540e1..90fd4d33486e1d53af751157415acb05b2cf1b48 100644

--- a/content/browser/frame_host/navigation_controller_delegate.h

+++ b/content/browser/frame_host/navigation_controller_delegate.h

@@ -51,10 +51,8 @@ class NavigationControllerDelegate {

const LoadCommittedDetails& load_details) = 0;

virtual bool NavigateToPendingEntry(

NavigationController::ReloadType reload_type) = 0;

- virtual void SetHistoryLengthAndPrune(

- const SiteInstance* site_instance,

- int merge_history_length,

- int32 minimum_page_id) = 0;

+ virtual void SetHistoryOffsetAndLength(int history_offset,

+ int history_length) = 0;

virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;

virtual void UpdateMaxPageID(int32 page_id) = 0;

virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')