content/browser/frame_host/navigation_controller_delegate.h - Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process.

Side by Side Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: charlie's fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

7	7

8 #include <string>	8 #include <string>

9 #include "content/public/browser/invalidate_type.h"	9 #include "content/public/browser/invalidate_type.h"

10 #include "content/public/browser/navigation_controller.h"	10 #include "content/public/browser/navigation_controller.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 virtual bool IsBeingDestroyed() const = 0;	44 virtual bool IsBeingDestroyed() const = 0;

45 virtual bool CanOverscrollContent() const = 0;	45 virtual bool CanOverscrollContent() const = 0;

46	46

47 // Methods from WebContentsImpl that NavigationControllerImpl needs to	47 // Methods from WebContentsImpl that NavigationControllerImpl needs to

48 // call.	48 // call.

49 virtual void NotifyBeforeFormRepostWarningShow() = 0;	49 virtual void NotifyBeforeFormRepostWarningShow() = 0;

50 virtual void NotifyNavigationEntryCommitted(	50 virtual void NotifyNavigationEntryCommitted(

51 const LoadCommittedDetails& load_details) = 0;	51 const LoadCommittedDetails& load_details) = 0;

52 virtual bool NavigateToPendingEntry(	52 virtual bool NavigateToPendingEntry(

53 NavigationController::ReloadType reload_type) = 0;	53 NavigationController::ReloadType reload_type) = 0;

54 virtual void SetHistoryLengthAndPrune(	54 virtual void SetHistoryOffsetAndLength(int history_offset,

55 const SiteInstance* site_instance,	55 int history_length) = 0;

56 int merge_history_length,

57 int32 minimum_page_id) = 0;

58 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;	56 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;

59 virtual void UpdateMaxPageID(int32 page_id) = 0;	57 virtual void UpdateMaxPageID(int32 page_id) = 0;

60 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,	58 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,

61 int32 page_id) = 0;	59 int32 page_id) = 0;

62 virtual void ActivateAndShowRepostFormWarningDialog() = 0;	60 virtual void ActivateAndShowRepostFormWarningDialog() = 0;

63 virtual bool HasAccessedInitialDocument() = 0;	61 virtual bool HasAccessedInitialDocument() = 0;

64	62

65 // This method is needed, since we are no longer guaranteed that the	63 // This method is needed, since we are no longer guaranteed that the

66 // embedder for NavigationController will be a WebContents object.	64 // embedder for NavigationController will be a WebContents object.

67 virtual WebContents* GetWebContents() = 0;	65 virtual WebContents* GetWebContents() = 0;

68	66

69 // Methods needed by InterstitialPageImpl.	67 // Methods needed by InterstitialPageImpl.

70 virtual bool IsHidden() = 0;	68 virtual bool IsHidden() = 0;

71 virtual void RenderFrameForInterstitialPageCreated(	69 virtual void RenderFrameForInterstitialPageCreated(

72 RenderFrameHost* render_frame_host) = 0;	70 RenderFrameHost* render_frame_host) = 0;

73 virtual void AttachInterstitialPage(	71 virtual void AttachInterstitialPage(

74 InterstitialPageImpl* interstitial_page) = 0;	72 InterstitialPageImpl* interstitial_page) = 0;

75 virtual void DetachInterstitialPage() = 0;	73 virtual void DetachInterstitialPage() = 0;

76 virtual void SetIsLoading(RenderViewHost* render_view_host,	74 virtual void SetIsLoading(RenderViewHost* render_view_host,

77 bool is_loading,	75 bool is_loading,

78 bool to_different_document,	76 bool to_different_document,

79 LoadNotificationDetails* details) = 0;	77 LoadNotificationDetails* details) = 0;

80 };	78 };

81	79

82 } // namespace content	80 } // namespace content

83	81

84 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_	82 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_

OLD	NEW