Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 743523005: Remove m_hasBlendMode from BeginTransparencyDisplayItem (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, slimming-paint-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove m_hasBlendMode from BeginTransparencyDisplayItem Reduces redundancy, since: (m_blendMode != WebBlendModeNormal) <=> m_hasBlendMode BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185653

Patch Set 1 #

Total comments: 3

Patch Set 2 : Simplify. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/paint/LayerPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/TransparencyDisplayItem.h View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/paint/TransparencyDisplayItem.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
fs
6 years, 1 month ago (2014-11-19 13:57:56 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp File Source/core/paint/LayerPainter.cpp (right): https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp#newcode113 Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ? renderer.style()->blendMode() : WebBlendModeNormal; RenderStyle::blendMode() is ...
6 years, 1 month ago (2014-11-19 19:16:05 UTC) #4
chrishtr
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp File Source/core/paint/LayerPainter.cpp (right): https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp#newcode113 Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ? renderer.style()->blendMode() : WebBlendModeNormal; On 2014/11/19 at ...
6 years, 1 month ago (2014-11-19 19:24:09 UTC) #5
Julien - ping for review
On 2014/11/19 at 19:24:09, chrishtr wrote: > https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp > File Source/core/paint/LayerPainter.cpp (right): > > https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp#newcode113 ...
6 years, 1 month ago (2014-11-19 20:00:42 UTC) #6
chrishtr
On 2014/11/19 at 20:00:42, jchaffraix wrote: > On 2014/11/19 at 19:24:09, chrishtr wrote: > > ...
6 years, 1 month ago (2014-11-19 20:09:41 UTC) #7
fs
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp File Source/core/paint/LayerPainter.cpp (right): https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPainter.cpp#newcode113 Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ? renderer.style()->blendMode() : WebBlendModeNormal; On 2014/11/19 19:16:05, ...
6 years, 1 month ago (2014-11-20 09:09:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743523005/20001
6 years, 1 month ago (2014-11-20 09:21:46 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 09:56:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185653

Powered by Google App Engine
This is Rietveld 408576698