Remove m_hasBlendMode from BeginTransparencyDisplayItem

Remove m_hasBlendMode from BeginTransparencyDisplayItem

Reduces redundancy, since:

 (m_blendMode != WebBlendModeNormal) <=> m_hasBlendMode

BUG=423071
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185653

[fs, 2014-11-19 10:22:59]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[Julien - ping for review, 2014-11-19 19:16:04]

jchaffraix@chromium.org changed reviewers:
+ jchaffraix@chromium.org

[Julien - ping for review, 2014-11-19 19:16:05]

lgtm

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ?
renderer.style()->blendMode() : WebBlendModeNormal;
RenderStyle::blendMode() is gated on cssCompositingEnabled too so you could just
use it directly and remove this function.

[chrishtr, 2014-11-19 19:24:09]

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ?
renderer.style()->blendMode() : WebBlendModeNormal;
On 2014/11/19 at 19:16:05, Julien Chaffraix - PST wrote:
> RenderStyle::blendMode() is gated on cssCompositingEnabled too so you could
just use it directly and remove this function.

Let's get rid of all of the hasBlendMode() methods, and rename
WebBlendModeNormal to WebBlendModeNone.

[Julien - ping for review, 2014-11-19 20:00:42]

On 2014/11/19 at 19:24:09, chrishtr wrote:
>
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
> File Source/core/paint/LayerPainter.cpp (right):
> 
>
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
> Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ?
renderer.style()->blendMode() : WebBlendModeNormal;
> On 2014/11/19 at 19:16:05, Julien Chaffraix - PST wrote:
> > RenderStyle::blendMode() is gated on cssCompositingEnabled too so you could
just use it directly and remove this function.
> 
> Let's get rid of all of the hasBlendMode() methods, and rename
WebBlendModeNormal to WebBlendModeNone.

I agree on removing hasBlendMode(). But the renaming is a terrible idea: the
name comes from the specification (http://dev.w3.org/fxtf/compositing-1/) and
renaming it will only yield to confusion.

[chrishtr, 2014-11-19 20:09:41]

On 2014/11/19 at 20:00:42, jchaffraix wrote:
> On 2014/11/19 at 19:24:09, chrishtr wrote:
> >
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
> > File Source/core/paint/LayerPainter.cpp (right):
> > 
> >
https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
> > Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ?
renderer.style()->blendMode() : WebBlendModeNormal;
> > On 2014/11/19 at 19:16:05, Julien Chaffraix - PST wrote:
> > > RenderStyle::blendMode() is gated on cssCompositingEnabled too so you
could just use it directly and remove this function.
> > 
> > Let's get rid of all of the hasBlendMode() methods, and rename
WebBlendModeNormal to WebBlendModeNone.
> 
> I agree on removing hasBlendMode(). But the renaming is a terrible idea: the
name comes from the specification (http://dev.w3.org/fxtf/compositing-1/) and
renaming it will only yield to confusion.

Ok.

[fs, 2014-11-20 09:09:46]

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
File Source/core/paint/LayerPainter.cpp (right):

https://codereview.chromium.org/743523005/diff/1/Source/core/paint/LayerPaint...
Source/core/paint/LayerPainter.cpp:113: return renderer.hasBlendMode() ?
renderer.style()->blendMode() : WebBlendModeNormal;
On 2014/11/19 19:16:05, Julien Chaffraix - PST wrote:
> RenderStyle::blendMode() is gated on cssCompositingEnabled too so you could
just
> use it directly and remove this function.

Ah, but of course... Thanks, fixed.

[fs, 2014-11-20 09:20:58]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-11-20 09:21:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/743523005/20001

[commit-bot: I haz the power, 2014-11-20 09:56:40]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185653