Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/core/paint/TransparencyDisplayItem.h

Issue 743523005: Remove m_hasBlendMode from BeginTransparencyDisplayItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Simplify. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/paint/LayerPainter.cpp ('k') | Source/core/paint/TransparencyDisplayItem.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TransparencyDisplayItem_h 5 #ifndef TransparencyDisplayItem_h
6 #define TransparencyDisplayItem_h 6 #define TransparencyDisplayItem_h
7 7
8 #include "core/paint/ViewDisplayList.h" 8 #include "core/paint/ViewDisplayList.h"
9 #include "platform/geometry/LayoutRect.h" 9 #include "platform/geometry/LayoutRect.h"
10 #include "public/platform/WebBlendMode.h" 10 #include "public/platform/WebBlendMode.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class BeginTransparencyDisplayItem : public DisplayItem { 14 class BeginTransparencyDisplayItem : public DisplayItem {
15 public: 15 public:
16 BeginTransparencyDisplayItem(const RenderObject* renderer, Type type, const LayoutRect& clipRect, bool hasBlendMode, const WebBlendMode& blendMode, const fl oat opacity) 16 BeginTransparencyDisplayItem(const RenderObject* renderer, Type type, const LayoutRect& clipRect, const WebBlendMode& blendMode, const float opacity)
17 : DisplayItem(renderer, type) 17 : DisplayItem(renderer, type)
18 , m_clipRect(clipRect) 18 , m_clipRect(clipRect)
19 , m_hasBlendMode(hasBlendMode)
20 , m_blendMode(blendMode) 19 , m_blendMode(blendMode)
21 , m_opacity(opacity) { } 20 , m_opacity(opacity) { }
22 virtual void replay(GraphicsContext*) override; 21 virtual void replay(GraphicsContext*) override;
23 22
24 private: 23 private:
25
26 #ifndef NDEBUG 24 #ifndef NDEBUG
27 virtual WTF::String asDebugString() const override; 25 virtual WTF::String asDebugString() const override;
28 #endif 26 #endif
29 27
28 bool hasBlendMode() const { return m_blendMode != WebBlendModeNormal; }
29
30 const LayoutRect m_clipRect; 30 const LayoutRect m_clipRect;
31 const bool m_hasBlendMode;
32 const WebBlendMode m_blendMode; 31 const WebBlendMode m_blendMode;
33 const float m_opacity; 32 const float m_opacity;
34 }; 33 };
35 34
36 class EndTransparencyDisplayItem : public DisplayItem { 35 class EndTransparencyDisplayItem : public DisplayItem {
37 public: 36 public:
38 EndTransparencyDisplayItem(const RenderObject* renderer, Type type) 37 EndTransparencyDisplayItem(const RenderObject* renderer, Type type)
39 : DisplayItem(renderer, type) { } 38 : DisplayItem(renderer, type) { }
40 virtual void replay(GraphicsContext*) override; 39 virtual void replay(GraphicsContext*) override;
41 40
42 private: 41 private:
43 #ifndef NDEBUG 42 #ifndef NDEBUG
44 virtual WTF::String asDebugString() const override; 43 virtual WTF::String asDebugString() const override;
45 #endif 44 #endif
46 }; 45 };
47 46
48 } // namespace blink 47 } // namespace blink
49 48
50 #endif // TransparencyDisplayItem_h 49 #endif // TransparencyDisplayItem_h
OLDNEW
« no previous file with comments | « Source/core/paint/LayerPainter.cpp ('k') | Source/core/paint/TransparencyDisplayItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698