Issue 743423002: Chromecast: removes CastMetricsServiceClient unit test from GYP file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 743423002: Chromecast: removes CastMetricsServiceClient unit test from GYP file. (Closed)

Created:
6 years, 1 month ago by gunsch

Modified:
6 years, 1 month ago

Reviewers:
lcwu1

CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Chromecast: removes CastMetricsServiceClient unit test from GYP file. https://codereview.chromium.org/719353005/ and https://codereview.chromium.org/739663003/ crossed paths, and I ended up with a GYP rule in chromecast_tests.gypi, but no test file. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/fb34d46fae20760df6448f556dd70ca776ad6bdb Cr-Commit-Position: refs/heads/master@{#305149}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -23 lines)			Patch
	M	chromecast/chromecast_tests.gypi	View		2 chunks	+0 lines, -23 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743423002/1

6 years, 1 month ago (2014-11-21 01:20:18 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-21 02:06:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fb34d46fae20760df6448f556dd70ca776ad6bdb
Cr-Commit-Position: refs/heads/master@{#305149}