Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 739663003: Removes the test to create CastMetricsServiceClient. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removes the test to create CastMetricsServiceClient. This is covered by the end-to-end browser test. R=lcwu@chromium.org BUG=None Committed: https://crrev.com/4f1a2509c4fbd06cf99418df3193f83812f4d719 Cr-Commit-Position: refs/heads/master@{#304703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
D chromecast/browser/metrics/cast_metrics_service_client_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
6 years, 1 month ago (2014-11-18 21:20:23 UTC) #1
lcwu1
lgtm
6 years, 1 month ago (2014-11-18 22:22:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739663003/1
6 years, 1 month ago (2014-11-18 22:25:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 23:56:50 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 23:57:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f1a2509c4fbd06cf99418df3193f83812f4d719
Cr-Commit-Position: refs/heads/master@{#304703}

Powered by Google App Engine
This is Rietveld 408576698