Issue 743003: Send mouse events to the renderer before changing mouse capture, so that the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 743003: Send mouse events to the renderer before changing mouse capture, so that the ... (Closed)

Created:
10 years, 9 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, brettw+cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Send mouse events to the renderer before changing mouse capture, so that the mousecapturelost arrives after mouseup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41113

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	1	2 chunks	+5 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/743003/diff/3001/4001 File chrome/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/743003/diff/3001/4001#newcode1563 chrome/browser/renderer_host/render_widget_host_view_win.cc:1563: render_widget_host_->ForwardMouseEvent(event); LGTM I think you should make a similar ...

10 years, 9 months ago (2010-03-10 00:14:05 UTC) #2

jam

10 years, 9 months ago (2010-03-10 01:51:19 UTC) #3

http://codereview.chromium.org/743003/diff/3001/4001
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/743003/diff/3001/4001#newcode1563
chrome/browser/renderer_host/render_widget_host_view_win.cc:1563:
render_widget_host_->ForwardMouseEvent(event);
On 2010/03/10 00:14:06, darin wrote:
> LGTM
> 
> I think you should make a similar change to WebWidgetHost::MouseEvent.

good idea, thanks.  will add it and commit.

Expand Messages | Collapse Messages

Issue 743003: Send mouse events to the renderer before changing mouse capture, so that the ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages