Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6828)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.cc

Issue 743003: Send mouse events to the renderer before changing mouse capture, so that the ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_win.cc
===================================================================
--- chrome/browser/renderer_host/render_widget_host_view_win.cc (revision 40968)
+++ chrome/browser/renderer_host/render_widget_host_view_win.cc (working copy)
@@ -1557,6 +1557,11 @@
WebMouseEvent event(
WebInputEventFactory::mouseEvent(m_hWnd, message, wparam, lparam));
+
+ // Send the event to the renderer before changing mouse capture, so that the
+ // capturelost event arrives after mouseup.
+ render_widget_host_->ForwardMouseEvent(event);
darin (slow to review) 2010/03/10 00:14:06 LGTM I think you should make a similar change to
jam 2010/03/10 01:51:19 good idea, thanks. will add it and commit.
+
switch (event.type) {
case WebInputEvent::MouseMove:
TrackMouseLeave(true);
@@ -1573,8 +1578,6 @@
break;
}
- render_widget_host_->ForwardMouseEvent(event);
-
if (activatable_ && event.type == WebInputEvent::MouseDown) {
// This is a temporary workaround for bug 765011 to get focus when the
// mouse is clicked. This happens after the mouse down event is sent to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698