Unschedule the SVG filter layer update hack after detaching children

Unschedule the SVG filter layer update hack after detaching children

This patch fixes a crash where an element is scheduled for an update
while being detached.

When an element is being detached it would clear the update flag then
detach its children. This is problematic because children can set the
update flag on elements during detach (which is expected). If a child
sets an element as needing an update while that element is being
detached, we'll end up with a detached element that needs a filter update
which can make Document::dirtyElementsForLayerUpdate angry.

When scheduling, we check that an element does not need an attach
(which would handle the filter layer update) before actually scheduling.
This patch moves unscheduling after the element is in a needsAttach state.

Looking forward to removing this hack entirely..

R=esprehn
BUG=429666
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185670

[pdr., 2014-11-19 07:01:09]

pdr@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2014-11-20 14:43:38]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2014-11-20 14:43:39]

lgtm

[commit-bot: I haz the power, 2014-11-20 14:43:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/742693002/20001

[commit-bot: I haz the power, 2014-11-20 15:26:55]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185670