Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: Source/core/dom/Element.cpp

Issue 742693002: Unschedule the SVG filter layer update hack after detaching children (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: thanks find-copies Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/filters/filter-detach-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 522ab743c97b6f2eb78449f1d6d0d4fda5f84398..2c68009aa43e0c74aca597bac82dc6e34c4cb84f 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -1349,8 +1349,6 @@ void Element::detach(const AttachContext& context)
HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
cancelFocusAppearanceUpdate();
removeCallbackSelectors();
- if (svgFilterNeedsLayerUpdate())
- document().unscheduleSVGFilterLayerUpdateHack(*this);
if (hasRareData()) {
ElementRareData* data = elementRareData();
data->clearPseudoElements();
@@ -1377,7 +1375,12 @@ void Element::detach(const AttachContext& context)
if (ElementShadow* shadow = data->shadow())
shadow->detach(context);
}
+
ContainerNode::detach(context);
+
+ ASSERT(needsAttach());
+ if (svgFilterNeedsLayerUpdate())
+ document().unscheduleSVGFilterLayerUpdateHack(*this);
}
bool Element::pseudoStyleCacheIsInvalid(const RenderStyle* currentStyle, RenderStyle* newStyle)
« no previous file with comments | « LayoutTests/svg/filters/filter-detach-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698