Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 742663002: add roundOut that returns its result (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add roundOut that returns its result BUG=skia: Committed: https://skia.googlesource.com/skia/+/b07a94f1cba3976596ae1a7f23d8c2043ba353f3

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -53 lines) Patch
M include/core/SkRect.h View 2 chunks +11 lines, -8 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRasterClip.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMatrixImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
reed2
6 years, 1 month ago (2014-11-19 03:30:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742663002/1
6 years, 1 month ago (2014-11-19 03:32:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 03:32:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1050)
6 years, 1 month ago (2014-11-19 03:36:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742663002/20001
6 years, 1 month ago (2014-11-19 03:45:57 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 03:45:58 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-11-19 09:45:59 UTC) #12
robertphillips
lgtm
6 years, 1 month ago (2014-11-19 13:02:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742663002/20001
6 years, 1 month ago (2014-11-19 13:02:59 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 13:03:24 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b07a94f1cba3976596ae1a7f23d8c2043ba353f3

Powered by Google App Engine
This is Rietveld 408576698