Make breakpoints not crash sky

sky/engine/bindings/core/v8/V8Initializer.cpp

Index: sky/engine/bindings/core/v8/V8Initializer.cpp
diff --git a/sky/engine/bindings/core/v8/V8Initializer.cpp b/sky/engine/bindings/core/v8/V8Initializer.cpp
index b45753b72a1323f020fd0dcbfdb12a90282fc637..dd36c02a2d32789e5b8b961bea216a83d1e12ae2 100644
--- a/sky/engine/bindings/core/v8/V8Initializer.cpp
+++ b/sky/engine/bindings/core/v8/V8Initializer.cpp
@@ -83,6 +83,26 @@ static void reportFatalErrorInMainThread(const char* location, const char* messa
     CRASH();
 }
 
+static LocalFrame* retrieveFrameWithGlobalObjectCheck(v8::Handle<v8::Context> context)
+{
+    if (context.IsEmpty())
+        return 0;
+
+    // FIXME: This is a temporary hack for crbug.com/345014.
+    // Currently it's possible that V8 can trigger Debugger::ProcessDebugEvent for a context
+    // that is being initialized (i.e., inside Context::New() of the context).
+    // We should fix the V8 side so that it won't trigger the event for a half-baked context
+    // because there is no way in the embedder side to check if the context is half-baked or not.
+    if (isMainThread() && DOMWrapperWorld::windowIsBeingInitialized())
+        return 0;
+
+    v8::Handle<v8::Value> global = V8Window::findInstanceInPrototypeChain(context->Global(), context->GetIsolate());
+    if (global.IsEmpty())
+        return 0;
+
+    return toFrameIfNotDetached(context);

[abarth-chromium, 2014/11/19 02:05:40]

If you're the only client of this function, you can simplify it a bit.  You
don't need to check isMainThread and you don't need to call toFrameIfNotDetached
because you're just interested in the bool result.

+}
+
 static void messageHandlerInMainThread(v8::Handle<v8::Message> message, v8::Handle<v8::Value> data)
 {
     ASSERT(isMainThread());
@@ -93,6 +113,13 @@ static void messageHandlerInMainThread(v8::Handle<v8::Message> message, v8::Hand
         return;
 
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
+    // Check if we're in the V8DebugContext which does not have a window object.
+    if (!retrieveFrameWithGlobalObjectCheck(isolate->GetCurrentContext())) {
+        printf("Unhandled: %s %s\n",
+            toCoreString(message->Get()).ascii().data(),
+            toCoreString(message->GetSourceLine()).ascii().data());
+        return;
+    }
     // If called during context initialization, there will be no entered window.
     LocalDOMWindow* enteredWindow = enteredDOMWindow(isolate);
     if (!enteredWindow)