sky/engine/bindings/core/v8/V8Binding.cpp - Issue 742583004: Make breakpoints not crash sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/core/v8/V8Binding.cpp

Issue 742583004: Make breakpoints not crash sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/core/v8/V8Binding.cpp

diff --git a/sky/engine/bindings/core/v8/V8Binding.cpp b/sky/engine/bindings/core/v8/V8Binding.cpp

index 99d512c638ec32834db43d3d4215cfef6162a641..585f2b2fe807db80d41a29c0f5bf340f668f105c 100644

--- a/sky/engine/bindings/core/v8/V8Binding.cpp

+++ b/sky/engine/bindings/core/v8/V8Binding.cpp

@@ -669,9 +669,7 @@ ExecutionContext* callingExecutionContext(v8::Isolate* isolate)

LocalFrame* toFrameIfNotDetached(v8::Handle<v8::Context> context)

{

- // FIXME(sky): remove.

- LocalDOMWindow* window = toDOMWindow(context);

- return window->frame();

+ return toDOMWindow(context)->frame();

}

v8::Local<v8::Context> toV8Context(ExecutionContext* context, DOMWrapperWorld& world)