Issue 742583004: Make breakpoints not crash sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 742583004: Make breakpoints not crash sky (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, yurys

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make breakpoints not crash sky They still don't work, but at least they don't crash. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d0266aa861985a7ca2da2b65c034ea717b515131

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -8 lines)			Patch
M	sky/engine/bindings/core/v8/V8Binding.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/engine/bindings/core/v8/V8Initializer.cpp	View	2 chunks	+27 lines, -0 lines	1 comment	Download
M	sky/framework/inspector/inspector.sky	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 (id:1) manually as d0266aa861985a7ca2da2b65c034ea717b515131.

6 years, 1 month ago (2014-11-19 01:39:24 UTC) #2

eseidel

My current theory for the exception down in debug-script.js is that our DebuggerScript.js and v8/debug-script.js ...

6 years, 1 month ago (2014-11-19 01:41:27 UTC) #3

abarth-chromium

6 years, 1 month ago (2014-11-19 02:05:40 UTC) #4

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/742583004/diff/1/sky/engine/bindings/core/v8/...
File sky/engine/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/742583004/diff/1/sky/engine/bindings/core/v8/...
sky/engine/bindings/core/v8/V8Initializer.cpp:103: return
toFrameIfNotDetached(context);
If you're the only client of this function, you can simplify it a bit.  You
don't need to check isMainThread and you don't need to call toFrameIfNotDetached
because you're just interested in the bool result.

Expand Messages | Collapse Messages