Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: Source/core/dom/AXObjectCache.h

Issue 742353004: Implement computedRole and computedName (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dmazzoni review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/AXObjectCache.h
diff --git a/Source/core/dom/AXObjectCache.h b/Source/core/dom/AXObjectCache.h
index a389c0d7f446208d0f70627e9f63122190d1accf..2415c94d067ddca6d4639befe2a019a248c5c396 100644
--- a/Source/core/dom/AXObjectCache.h
+++ b/Source/core/dom/AXObjectCache.h
@@ -120,10 +120,28 @@ public:
virtual void handleLayoutComplete(RenderObject*) = 0;
virtual void handleScrolledToAnchor(const Node* anchorNode) = 0;
+ virtual const AtomicString& computedRoleForNode(Node*) = 0;
+ virtual String computedNameForNode(Node*) = 0;
+
protected:
AXObjectCache();
};
+class ScopedAXObjectCache {
adamk 2014/12/16 23:56:49 Please add WTF_MAKE_NONCOPYABLE()
aboxhall 2014/12/17 02:06:24 Done.
+public:
+ explicit ScopedAXObjectCache(Document&);
+ ~ScopedAXObjectCache();
+
+ AXObjectCache* get();
+ AXObjectCache* operator->();
+
+private:
+
adamk 2014/12/16 23:56:49 No need for this empty line.
aboxhall 2014/12/17 02:06:24 It's for dramatic effect. (Just kidding.)
+ Document& m_document;
+ AXObjectCache* m_cache;
+ bool m_isScoped;
+};
+
}
#endif

Powered by Google App Engine
This is Rietveld 408576698