Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 742343002: cc: Move LayerRasterTileIterator to a separate file and make it a queue (Closed)

Created:
6 years, 1 month ago by vmpstr
Modified:
6 years ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Move LayerRasterTileIterator to a separate file and make it a queue This patch removes PictureLayerImpl::LayerRasterTileIterator, moves it to a separate file, renames it to TilingSetRasterQueue, and makes its functionality be more queue-like instead of iterator-like. Also, this patch adds a PLI::CreateRasterQueue to get a raster queue for the layer. This hides a bit more details of PLTS from PLI and allows us in the future to optimize or create other types of TilingSetRasterQueues. BUG=433048 R=reveman, enne Committed: https://crrev.com/bc22bb72cbb3fdef0216fb7eba164954cdfdd313 Cr-Commit-Position: refs/heads/master@{#307287}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -300 lines) Patch
M cc/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 3 chunks +2 lines, -30 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 chunks +8 lines, -119 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 1 6 chunks +21 lines, -24 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 14 chunks +29 lines, -33 lines 0 comments Download
M cc/resources/raster_tile_priority_queue.h View 3 chunks +11 lines, -10 lines 0 comments Download
M cc/resources/raster_tile_priority_queue.cc View 8 chunks +91 lines, -84 lines 0 comments Download
A cc/resources/tiling_set_raster_queue.h View 1 chunk +46 lines, -0 lines 0 comments Download
A cc/resources/tiling_set_raster_queue.cc View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
vmpstr
PTAL. I'll run some performance numbers in the morning to verify that this doesn't regress ...
6 years, 1 month ago (2014-11-21 00:32:09 UTC) #1
vmpstr
+e.hakkinen for review.
6 years ago (2014-11-25 17:40:01 UTC) #3
USE eero AT chromium.org
6 years ago (2014-11-27 13:09:19 UTC) #5
USE eero AT chromium.org
lgtm (as non-owner)
6 years ago (2014-11-27 13:15:07 UTC) #6
vmpstr
reveman@, could you take a look as well?
6 years ago (2014-12-03 14:23:54 UTC) #7
reveman
lgtm
6 years ago (2014-12-03 15:36:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742343002/20001
6 years ago (2014-12-05 23:57:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/35023)
6 years ago (2014-12-06 01:45:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742343002/20001
6 years ago (2014-12-08 17:46:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 18:38:24 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-08 18:39:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc22bb72cbb3fdef0216fb7eba164954cdfdd313
Cr-Commit-Position: refs/heads/master@{#307287}

Powered by Google App Engine
This is Rietveld 408576698