Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 74223002: remove references to DART_SDK from editor (Closed)

Created:
7 years, 1 month ago by danrubel
Modified:
7 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

remove references to DART_SDK from editor remove unused method BUG=dartbug.com/14967 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=30310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java View 2 chunks +2 lines, -27 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/BuildDartParticipant.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
Rather than warning the user, remove references to DART_SDK from editor now that no other ...
7 years, 1 month ago (2013-11-15 18:52:15 UTC) #1
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-11-15 18:59:25 UTC) #2
danrubel
7 years, 1 month ago (2013-11-15 19:04:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698