Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

Issue 74223002: remove references to DART_SDK from editor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/BuildDartParticipant.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java
index efed04c2c104f9bda5de95462cd27ef116a74508..3c5b18387079abc9e641ac3576e0b017e13d82a0 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java
@@ -81,11 +81,6 @@ public class DirectoryBasedDartSdk implements DartSdk {
private static final String CHROMIUM_DIRECTORY_NAME = "chromium"; //$NON-NLS-1$
/**
- * The name of the environment variable whose value is the path to the default Dart SDK directory.
- */
- private static final String DART_SDK_ENVIRONMENT_VARIABLE_NAME = "DART_SDK"; //$NON-NLS-1$
-
- /**
* The name of the file containing the Dartium executable on Linux.
*/
private static final String DARTIUM_EXECUTABLE_NAME_LINUX = "chrome"; //$NON-NLS-1$
@@ -173,36 +168,16 @@ public class DirectoryBasedDartSdk implements DartSdk {
}
/**
- * Return the default Dart SDK, or {@code null} if the directory containing the default SDK cannot
- * be determined (or does not exist).
- * <p>
- * Added in order to test AnalysisContextImpl2.
- *
- * @return the default Dart SDK
- */
- public static DirectoryBasedDartSdk getDefaultSdk2() {
- File sdkDirectory = getDefaultSdkDirectory();
- if (sdkDirectory == null) {
- return null;
- }
- return new DirectoryBasedDartSdk(sdkDirectory, true);
- }
-
- /**
* Return the default directory for the Dart SDK, or {@code null} if the directory cannot be
* determined (or does not exist). The default directory is provided by a {@link System} property
- * named {@code com.google.dart.sdk}, or, if the property is not defined, an environment variable
- * named {@code DART_SDK}.
+ * named {@code com.google.dart.sdk}.
*
* @return the default directory for the Dart SDK
*/
public static File getDefaultSdkDirectory() {
String sdkProperty = System.getProperty(DEFAULT_DIRECTORY_PROPERTY_NAME);
if (sdkProperty == null) {
- sdkProperty = System.getenv(DART_SDK_ENVIRONMENT_VARIABLE_NAME);
- if (sdkProperty == null) {
- return null;
- }
+ return null;
}
File sdkDirectory = new File(sdkProperty);
if (!sdkDirectory.exists()) {
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/BuildDartParticipant.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698