Source/core/fileapi/File.cpp - Issue 74213009: File constructor understands lastModified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/File.cpp

Issue 74213009: File constructor understands lastModified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed m_hasLastModifiedDate in release builds. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/fileapi/File.cpp

diff --git a/Source/core/fileapi/File.cpp b/Source/core/fileapi/File.cpp

index 684216160e44ee501cdacc56b3981e91449974fa..2190682a56603436dd2c7469387bace279e8cca0 100644

--- a/Source/core/fileapi/File.cpp

+++ b/Source/core/fileapi/File.cpp

@@ -161,8 +161,11 @@ File::File(const KURL& fileSystemURL, const FileMetadata& metadata)

double File::lastModifiedDate() const

{

- if (hasValidSnapshotMetadata() && isValidFileTime(m_snapshotModificationTime))

- return m_snapshotModificationTime * msPerSecond;

+ if (hasValidSnapshotMetadata()) {

+ if (isValidFileTime(m_snapshotModificationTime))

sof 2013/11/17 17:16:34 This check looks redundant also, just return "m_sn

pwnall-personal 2013/11/17 17:50:47 Done. Thank you!

+ return m_snapshotModificationTime * msPerSecond;

+ return m_snapshotModificationTime;

+ }

time_t modificationTime;

if (getFileModificationTime(m_path, modificationTime) && isValidFileTime(modificationTime))