File constructor understands lastModified.

Source/bindings/v8/custom/V8FileCustom.cpp

Index: Source/bindings/v8/custom/V8FileCustom.cpp
diff --git a/Source/bindings/v8/custom/V8FileCustom.cpp b/Source/bindings/v8/custom/V8FileCustom.cpp
index 6983ef2188946414cbbeb6a688c5b9914d1d3b51..fffa2ee1bd046364c0acaeb63458a6d9d483df96 100644
--- a/Source/bindings/v8/custom/V8FileCustom.cpp
+++ b/Source/bindings/v8/custom/V8FileCustom.cpp
@@ -62,25 +62,32 @@ void V8File::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, fileName, info[1]);
 
-    String contentType;
-    String endings = "transparent"; // default if no BlobPropertyBag is passed
+    V8BlobCustomHelpers::ParsedProperties properties(true);
     if (info.Length() > 2) {
         if (!info[2]->IsObject()) {
             throwTypeError(ExceptionMessages::failedToConstruct("File", "The 3rd argument is not of type Object."), info.GetIsolate());
             return;
         }
 
-        if (!V8BlobCustomHelpers::processBlobPropertyBag(info[2], "File", contentType, endings, info.GetIsolate()))
+        if (!V8BlobCustomHelpers::processBlobPropertyBag(info[2], "File", properties, info.GetIsolate()))
             return;
+    } else {
+        properties.setDefaultLastModifiedDate();
     }
 
     BlobBuilder blobBuilder;
     v8::Local<v8::Object> blobParts = v8::Local<v8::Object>::Cast(info[0]);
-    if (!V8BlobCustomHelpers::processBlobParts(blobParts, length, endings, blobBuilder, info.GetIsolate()))
+    if (!V8BlobCustomHelpers::processBlobParts(blobParts, length, properties.endings, blobBuilder, info.GetIsolate()))
         return;
 
-    RefPtr<File> file = blobBuilder.createFile(contentType, fileName, currentTime());
+    RefPtr<File> file = blobBuilder.createFile(properties.contentType, fileName, properties.lastModifiedDate());
     v8SetReturnValue(info, file.release());
 }
 
+void V8File::lastModifiedDateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+    File* file = V8File::toNative(info.Holder());
+    v8SetReturnValue(info, v8::Date::New(file->lastModifiedDate()));

[sof, 2013/11/17 17:16:34]

Well spotted (that you need a custom getter.)

This actually looks like a bug/limitation in the IDL code generator -- it
generating code that assumes that a NaN returned from the object getter is to be
given the interpretation that "HTMLInputElement.valueAsDate" has (where an
invalid date string maps to null, not a Date with a NaN [[PrimitiveValue]].)
Which is fine for Dates that are nullable (like valueAsDate is defined to be),
but not without (like here.)

Looks easy to fix, but that can be done as a slightly wider followup. I
suppose... I'll leave that to the reviewers :-)

[pwnall-personal, 2013/11/17 17:50:47]

I'd be happy to change the code generator to account for non-nullable Date
instances, if that is desirable.

I'm slightly biased towards making it happen in a different CL, so there's less
to revert if something breaks, but I will do what the reviewers think is best.

+}
+
 } // namespace WebCore