Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7419: Move many files that were suffixed Win.cpp to Chromium.cpp, and place them in... (Closed)

Created:
12 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
tony, dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move many files that were suffixed Win.cpp to Chromium.cpp, and place them in chromium/ subdirectories. We still build these files with PLATFORM(WIN) defined. In this change, I also killed off LogWin.{h,cpp} since we don't use it. So, you will see some changes related to that. R=dglazkov,tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3427

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -10397 lines) Patch
M webkit/SConscript.port View 1 2 5 chunks +62 lines, -45 lines 0 comments Download
M webkit/build/glue/glue.vcproj View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/build/port/port.vcproj View 1 2 7 chunks +239 lines, -223 lines 0 comments Download
M webkit/build/webkit_common_includes.vsprops View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/chrome_client_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/editor_client_impl.cc View 1 2 10 chunks +21 lines, -29 lines 0 comments Download
A + webkit/glue/resource_handle_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/glue/resource_handle_win.cc View 1 2 1 chunk +0 lines, -742 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 1 2 13 chunks +12 lines, -14 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webwidget_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/port/bridge/FrameWin.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/port/bridge/FrameWin.cpp View 1 2 1 chunk +0 lines, -105 lines 0 comments Download
D webkit/port/bridge/PageWin.cpp View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/port/bridge/PluginsWin.cpp View 1 2 1 chunk +0 lines, -153 lines 0 comments Download
A + webkit/port/bridge/chromium/PluginsChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/port/page/AXObjectCacheWin.cpp View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/port/page/AccessibilityObjectWin.cpp View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D webkit/port/page/ChromeClientWin.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D webkit/port/page/DragControllerWin.cpp View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
D webkit/port/page/EventHandlerWin.cpp View 1 2 1 chunk +0 lines, -157 lines 0 comments Download
A + webkit/port/page/chromium/AXObjectCacheChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/page/chromium/AccessibilityObjectChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/page/chromium/ChromeClientChromium.h View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/port/page/chromium/DragControllerChromium.cpp View 2 chunks +10 lines, -1 line 0 comments Download
A + webkit/port/page/chromium/EventHandlerChromium.cpp View 3 chunks +9 lines, -2 lines 0 comments Download
A + webkit/port/page/chromium/FrameChromium.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/port/page/chromium/FrameChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
A webkit/port/page/win/FrameWin.h View 1 chunk +2 lines, -0 lines 0 comments Download
D webkit/port/platform/BString.h View 1 2 1 chunk +0 lines, -81 lines 0 comments Download
D webkit/port/platform/BString.cpp View 1 2 1 chunk +0 lines, -194 lines 0 comments Download
D webkit/port/platform/COMPtr.h View 1 2 1 chunk +0 lines, -151 lines 0 comments Download
D webkit/port/platform/ClipboardUtilitiesWin.h View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/port/platform/ClipboardUtilitiesWin.cpp View 1 2 1 chunk +0 lines, -323 lines 0 comments Download
D webkit/port/platform/ClipboardWin.h View 1 2 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/port/platform/ClipboardWin.cpp View 1 2 1 chunk +0 lines, -808 lines 0 comments Download
D webkit/port/platform/ContextMenuItemWin.cpp View 1 2 1 chunk +0 lines, -108 lines 0 comments Download
D webkit/port/platform/ContextMenuWin.cpp View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/port/platform/CursorWin.cpp View 1 2 1 chunk +0 lines, -326 lines 0 comments Download
D webkit/port/platform/DragDataWin.cpp View 1 2 1 chunk +0 lines, -183 lines 0 comments Download
D webkit/port/platform/DragImageWin.cpp View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D webkit/port/platform/EditorWin.cpp View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/port/platform/FileChooserWin.cpp View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
D webkit/port/platform/FramelessScrollView.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/port/platform/FramelessScrollView.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/port/platform/KeyEventWin.cpp View 1 2 1 chunk +0 lines, -209 lines 0 comments Download
D webkit/port/platform/LogWin.h View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/port/platform/LogWin.cpp View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/port/platform/MimeTypeRegistryWin.cpp View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D webkit/port/platform/PasteboardWin.cpp View 1 2 1 chunk +0 lines, -223 lines 0 comments Download
D webkit/port/platform/PlatformMouseEventWin.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/port/platform/PlatformScrollBar.h View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D webkit/port/platform/PlatformScrollBarWin.cpp View 1 2 1 chunk +0 lines, -796 lines 0 comments Download
D webkit/port/platform/PopupMenuWin.cpp View 1 2 1 chunk +0 lines, -1115 lines 0 comments Download
D webkit/port/platform/SSLKeyGeneratorWin.cpp View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D webkit/port/platform/ScreenWin.cpp View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
D webkit/port/platform/ScrollViewWin.cpp View 1 2 1 chunk +0 lines, -1229 lines 0 comments Download
D webkit/port/platform/SearchPopupMenuWin.cpp View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/port/platform/SharedTimerWin.cpp View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D webkit/port/platform/SoundWin.cpp View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/port/platform/SystemTimeWin.cpp View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
D webkit/port/platform/TemporaryLinkStubs.cpp View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/port/platform/TextBoundariesWin.cpp View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
D webkit/port/platform/TextBreakIteratorInternalICUWin.cpp View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D webkit/port/platform/WCDataObject.h View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D webkit/port/platform/WCDataObject.cpp View 1 2 1 chunk +0 lines, -382 lines 0 comments Download
D webkit/port/platform/WheelEventWin.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/port/platform/WidgetClientWin.h View 1 2 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/port/platform/WidgetWin.cpp View 1 2 1 chunk +0 lines, -228 lines 0 comments Download
A + webkit/port/platform/chromium/ContextMenuChromium.cpp View 3 chunks +3 lines, -14 lines 0 comments Download
A + webkit/port/platform/chromium/ContextMenuItemChromium.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
A + webkit/port/platform/chromium/CursorChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/DragDataChromium.cpp View 3 chunks +9 lines, -1 line 0 comments Download
A + webkit/port/platform/chromium/DragImageChromium.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
A + webkit/port/platform/chromium/FileChooserChromium.cpp View 3 chunks +9 lines, -4 lines 0 comments Download
A + webkit/port/platform/chromium/FramelessScrollView.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/FramelessScrollView.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/port/platform/chromium/Language.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
A + webkit/port/platform/chromium/MimeTypeRegistryChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/PlatformScrollBar.h View 1 chunk +0 lines, -4 lines 0 comments Download
A + webkit/port/platform/chromium/PlatformScrollBarChromium.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/port/platform/chromium/PopupMenuChromium.cpp View 6 chunks +7 lines, -17 lines 0 comments Download
A + webkit/port/platform/chromium/SSLKeyGeneratorChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/ScrollViewChromium.cpp View 9 chunks +16 lines, -13 lines 0 comments Download
A + webkit/port/platform/chromium/SearchPopupMenuChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/SharedTimerChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/SystemTimeChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/TemporaryLinkStubs.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/TextBoundariesChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/TextBreakIteratorInternalICUChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/chromium/WidgetChromium.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/port/platform/chromium/WidgetClientChromium.h View 3 chunks +5 lines, -5 lines 0 comments Download
D webkit/port/platform/network/AuthenticationChallenge.h View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D webkit/port/platform/network/AuthenticationChallenge.cpp View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/port/platform/network/CookieJarWin.cpp View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/port/platform/network/DNS.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/port/platform/network/NetworkStateNotifierWin.cpp View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D webkit/port/platform/network/ResourceError.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/port/platform/network/ResourceRequest.h View 1 2 1 chunk +0 lines, -139 lines 0 comments Download
D webkit/port/platform/network/ResourceResponse.h View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
A + webkit/port/platform/network/chromium/AuthenticationChallenge.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/network/chromium/AuthenticationChallengeChromium.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
A + webkit/port/platform/network/chromium/CookieJarChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/network/chromium/DNSChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/network/chromium/NetworkStateNotifierChromium.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
A + webkit/port/platform/network/chromium/ResourceError.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/network/chromium/ResourceRequest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/network/chromium/ResourceResponse.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/BString.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/BString.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/COMPtr.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/ClipboardUtilitiesWin.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/ClipboardUtilitiesWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/ClipboardWin.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/ClipboardWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/EditorWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/KeyEventWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/PasteboardWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/PlatformMouseEventWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/port/platform/win/README View 1 chunk +2 lines, -0 lines 0 comments Download
A + webkit/port/platform/win/ScreenWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/SoundWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/WCDataObject.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/WCDataObject.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/port/platform/win/WheelEventWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/port/plugins/PluginDataChromium.cpp View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
A + webkit/port/plugins/chromium/PluginDataChromium.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
12 years, 2 months ago (2008-10-15 21:24:11 UTC) #1
dglazkov
Holy Crap! LGTM.
12 years, 2 months ago (2008-10-15 21:33:17 UTC) #2
tony
12 years, 2 months ago (2008-10-15 21:46:31 UTC) #3 
LGTM.  All those files build on linux and mac?  Nice!

Powered by Google App Engine
This is Rietveld 408576698