Remove canCollapseAnonymousBlockChild.

Remove canCollapseAnonymousBlockChild.

The only place it's used now is making it so that
anonymous flex items don't do ellipsizing the same
way anonymous items inside a block would. This
is something we don't need, especially now that
we only have anonymous paragraphs around text nodes.

It's not clear to me if we want this looking at the
parent behavior at all, but that's something that
can be fixed in a followup.

Also delete some dead anonymous block functions.

R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/259bc325da7321a699f86554aad4c3dca1d6771a

[ojan, 2014-11-20 00:54:07]

ojan@chromium.org changed reviewers:
+ eseidel@chromium.org

[esprehn, 2014-11-20 19:06:54]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2014-11-20 19:06:54]

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockLineLayout.cpp:1217: || (isAnonymousBlock()
&& parent() && parent()->style()->textOverflow() &&
parent()->hasOverflowClip());
You lost the check for parent()->isRenderBlock(), why is that okay?

[ojan, 2014-11-20 19:25:53]

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockLineLayout.cpp:1217: || (isAnonymousBlock()
&& parent() && parent()->style()->textOverflow() &&
parent()->hasOverflowClip());
On 2014/11/20 19:06:54, esprehn wrote:
> You lost the check for parent()->isRenderBlock(), why is that okay?

That was just to make the toRenderBlock(parent()) call safe.

FWIW, I think we want to delete this line of code entirely and stop looking at
the parent's style at all, but I want to test exactly what it does before
removing it.

[esprehn, 2014-11-20 22:20:45]

lgtm ok

[ojan, 2014-11-20 23:28:41]

Committed patchset #1 (id:1) manually as
259bc325da7321a699f86554aad4c3dca1d6771a (presubmit successful).

[ojan, 2014-11-21 05:37:14]

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/741893002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockLineLayout.cpp:1217: || (isAnonymousBlock()
&& parent() && parent()->style()->textOverflow() &&
parent()->hasOverflowClip());
On 2014/11/20 at 19:25:53, ojan wrote:
> On 2014/11/20 19:06:54, esprehn wrote:
> > You lost the check for parent()->isRenderBlock(), why is that okay?
> 
> That was just to make the toRenderBlock(parent()) call safe.
> 
> FWIW, I think we want to delete this line of code entirely and stop looking at
the parent's style at all, but I want to test exactly what it does before
removing it.

See https://codereview.chromium.org/751483002#msg2. I think this new behavior is
correct assuming we decide to keep anonymous blocks at all.