Fix bug from 3db9471ae80bd492f2a346113d2323ba8eee0c09.

Fix text-overflow:ellipsis.

This regressed in 3db9471ae80bd492f2a346113d2323ba8eee0c09.

Accidentally sent some code down the override by sending the
top LayoutUnit instead of the left/right LayoutUnit. The
root problem was bad overloading, which is also fixed in
this patch. Inlined the overloaded method since one of
the calls was only called from one place.

The new test demonstrates the ellipsizing, but that doesn't
show through in the render tree dump. We don't get real
test coverage here until we either start doing pixel tests
or start exposing ellipsis in the render tree dumps.

R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/dee89ae6f794d0a28fa9d33e7485ae60c7a43e18

[ojan, 2014-11-21 05:35:50]

ojan@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org, esprehn@chromium.org

[ojan, 2014-11-21 05:35:51]

https://codereview.chromium.org/751483002/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/751483002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockLineLayout.cpp:1211: //     2) If you're an
anonymous paragraph with a parent that satisfies #1.
This code changed in https://codereview.chromium.org/741893002/. Updating the
comment. I now believe we want the currently checked in behavior on line 1216,
assuming we keep anonymous blocks at all. With the current code it means that a
text node directly inside a display:block will still ellipsize, which seems like
the right behavior to me. Not doing this with flexbox has been a constant stream
of real-world bugs being filed.

https://codereview.chromium.org/751483002/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockLineLayout.cpp:1514: float logicalLeft =
logicalLeftOffsetForLine(firstLine).toFloat();
These lines and the ones below are the bug. We're passing lineTop() as the
horizontal offset. :( With the changes in the header, there is no longer a
method called logicalLeftOffsetForLine that takes a LayoutUnit as it's first
argument.

[esprehn, 2014-11-21 06:10:44]

lgtm, it would be nice to give the patch a better title than "fixed a bug",
maybe "Fix line width computation for elipsis" and then mention the hash in the
description.

[ojan, 2014-11-21 19:26:09]

Committed patchset #1 (id:1) manually as
dee89ae6f794d0a28fa9d33e7485ae60c7a43e18 (presubmit successful).