Revert of Reland of Different fonts selected for width calculation

Revert of Reland of Different fonts selected for width calculation (patchset #4 id:60001 of https://codereview.chromium.org/680213004/)

Reason for revert:
Layout tests are failing: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftext%2Ftext-overflow-ellipsis-svgfont.html&testType=layout-tests

Original issue's description:
> Reland of Different fonts selected for width calculation 
> Original Patch: https://codereview.chromium.org/593673003/ due to
> issues faced in XP for which test expectation was not updated and
> revert of patch was submitted
> 
> In some cases different fonts are selected to get width of string and
> to draw text. In Font.cpp calls, font get changed due to fallback font
> architecture. When making calls we need to check if Unicode is present
> in primary font or not.
> In case of Ellipsis, we need to check if Ellipsis Unicode is present in
> primary font or not, if not then use "Dot" Unicode, this is also
> suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/)
> 
> BUG=416425
TEST=fast/text/ellipsis-platform-font-change.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186162

TBR=eae@chromium.org,tkent@chromium.org,pdr@chromium.org,h.joshi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=416425
TEST=fast/text/ellipsis-platform-font-change.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186206

[pfeldman, 2014-11-30 14:55:00]

Created Revert of Reland of Different fonts selected for width calculation

[commit-bot: I haz the power, 2014-11-30 14:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741803003/1

[commit-bot: I haz the power, 2014-11-30 14:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-30 14:55:49]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 succeeded at 1337 (offset 4 lines).
  Hunk #2 FAILED at 1397.
  1 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
d1e565e5331900da30431179f74565f04ad0131e..14de91d89a61d1aa08be334d00e51e2cad268e3b
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1333,6 +1333,7 @@
 crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/bidi-explicit-embedding-past-end.html [ Failure ]
 crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/cg-fallback-bolding.html [ Failure ]
 crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/decorations-transformed.html [ Failure ]
+crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/ellipsis-stroked.html [ ImageOnlyFailure ]
 crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/emphasis-avoid-ruby.html [ Failure ]
 crbug.com/429133 [ SnowLeopard ]
virtual/textblob/fast/text/emphasis-overlap.html [ Failure ]
 crbug.com/429133 [ SnowLeopard ] virtual/textblob/fast/text/fake-italic.html [
Failure ]
@@ -1396,17 +1397,8 @@
 
 crbug.com/435342 media/video-seeking.html [ Pass Failure ]
 
+crbug.com/435525 [ Mac Debug ] svg/W3C-SVG-1.1/struct-frag-02-t.svg [
NeedsManualRebaseline ]
+
 crbug.com/436436 fast/dom/HTMLImageElement/image-srcset-w-onerror.html [ Pass
Failure ]
 
-# Test case needs to be updated after
https://codereview.chromium.org/680213004/
-crbug.com/416425 fast/text/ellipsis-platform-font-change.html [ NeedsRebaseline
]
-crbug.com/416425 [ Mac Win ]
virtual/antialiasedtext/fast/text/ellipsis-platform-font-change.html [
NeedsRebaseline ]
-crbug.com/416425 svg/text/text-overflow-ellipsis-svgfont.html [ NeedsRebaseline
]
-crbug.com/416425 [ Win XP Linux ] fast/text/line-break-after-question-mark.html
[ NeedsRebaseline ]
-crbug.com/416425 fast/css/font-face-opentype.html [ NeedsRebaseline ]
-crbug.com/416425 virtual/textblob/fast/text/ellipsis-platform-font-change.html
[ NeedsRebaseline ]
-crbug.com/416425 virtual/textblob/fast/text/ellipsis-stroked.html [
ImageOnlyFailure ]
-crbug.com/416425 virtual/textblob/svg/text/text-overflow-ellipsis-svgfont.html
[ NeedsRebaseline ]
-
 crbug.com/364225 virtual/gpu/fast/canvas/canvas-composite-text-alpha.html [
Pass Slow Timeout ]
-crbug.com/435525 [ Mac Debug ] svg/W3C-SVG-1.1/struct-frag-02-t.svg [
NeedsRebaseline ]

[pfeldman, 2014-11-30 18:20:26]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-11-30 18:21:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741803003/230001

[commit-bot: I haz the power, 2014-11-30 18:22:16]

Committed patchset #2 (id:230001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186206

[h.joshi, 2014-12-01 04:16:53]

@pfeldman: Patch revert was not required, we need to update Test Expectation
file for the test failing.

Blink was not using correct font to calculate text width and ellipsis. Due to
this
Blink was returning wrong width of rendered text. Submitted patch was fixing
this issue.

[h.joshi, 2014-12-01 04:21:43]

@pfeldman: Cross checked the Test Expectation file and test case 
"virtual/textblob/svg/text/text-overflow-ellipsis-svgfont.html" is marked as
"NeedsRebaseline"

Request you to pls revert your patch.

[pfeldman, 2014-12-01 05:07:04]

- Auto rebaseline has landed new expectations for your tests as
https://src.chromium.org/viewvc/blink?revision=186173&view=revision.
- It made svg/text/text-overflow-ellipsis-svgfont.html and its virtual friends
flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg...

So it seems like there is something wrong with you patch and I should not
re-land it.

[h.joshi, 2014-12-01 07:16:53]

@pfeldman: I have two points here
1. Does not seems to be issue with submitted patch (I re-checked patch), patch
checks for the actual font
properties which will be used for final rendering.

2. I feel this SVG font test case is not valid now and can be removed, as SVG
font support was removed
5-6 months ago from Blink depending on usage metrics.
Pls suggest.

[pfeldman, 2014-12-01 07:28:42]

You should investigate the source of flakiness that your change introduced. If
the test in question itself needs to be removed, you could do that beforehand. I
would also suggest that you explore the patch that auto rebaseline bot landed
for you - it seems to contain too many new platfrom specifics. I am not sure it
was expected.

[h.joshi, 2014-12-01 07:38:51]

Platform specific rebaseline was needed, as patch checks for Font property
and fonts are platform specific.
Will check for test case and if test case itself needs to be removed, will 
do that first.