Adding MOJO_HANDLE_SIGNAL_PEER_CLOSED to be notified when a peer is closed.

Adding MOJO_HANDLE_SIGNAL_PEER_CLOSED to be notified when a peer is closed.

BUG=436227
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/33c847886a0ba611d5de113dcdb74bb99fa8e382

[qsr, 2014-11-25 17:21:47]

Trung, this is missing tests, as I'm writing those right now, but could you take
a preliminary look at:

mojo/edk/system/local_data_pipe.cc
mojo/edk/system/local_message_pipe_endpoint.cc
mojo/public/c/system/types.h

and confirm that you are fine with the names and implementation.

Thanks.

[viettrungluu, 2014-11-25 18:37:12]

The implementation looks fine.

I bikeshedded on the name a bit. :-P

https://codereview.chromium.org/741503003/diff/1/mojo/public/c/system/types.h
File mojo/public/c/system/types.h (right):

https://codereview.chromium.org/741503003/diff/1/mojo/public/c/system/types.h...
mojo/public/c/system/types.h:152: //   |MOJO_HANDLE_SIGNAL_CLOSED| - The remote
handle is closed.
Maybe it should be ..._REMOTE_CLOSED, to make it clear that it's not a signal
about the handle being waited on.

Or maybe ..._PEER_CLOSED (in which case you should update the explanation on the
right too), to bikeshed a bit. (I prefer this term, since "remote" is a bit
loaded.)

[qsr, 2014-11-26 15:46:05]

Ok, changed to PEER_CLOSED. Also added tests, and this is now ready for review.

Thanks.

[viettrungluu, 2014-11-26 18:01:51]

LGTM, thanks.

[qsr, 2014-11-27 09:07:37]

Committed patchset #3 (id:40001) manually as
33c847886a0ba611d5de113dcdb74bb99fa8e382 (presubmit successful).