mojo/edk/system/channel_unittest.cc - Issue 741503003: Adding MOJO_HANDLE_SIGNAL_PEER_CLOSED to be notified when a peer is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/channel_unittest.cc

Issue 741503003: Adding MOJO_HANDLE_SIGNAL_PEER_CLOSED to be notified when a peer is closed. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix go formatting Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/channel_unittest.cc

diff --git a/mojo/edk/system/channel_unittest.cc b/mojo/edk/system/channel_unittest.cc

index 68b1315a2b522a67bc1b0d9f78a2d9b4ffc574cd..e84ab5bea03debcaca41692105ae85ce35d6f4ca 100644

--- a/mojo/edk/system/channel_unittest.cc

+++ b/mojo/edk/system/channel_unittest.cc

@@ -243,8 +243,8 @@ TEST_F(ChannelTest, ShutdownAfterAttach) {

waiter.Wait(MOJO_DEADLINE_INDEFINITE, nullptr));

HandleSignalsState hss;

mp->RemoveWaiter(0, &waiter, &hss);

- EXPECT_EQ(0u, hss.satisfied_signals);

- EXPECT_EQ(0u, hss.satisfiable_signals);

+ EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfied_signals);

+ EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfiable_signals);

mp->Close(0);

@@ -279,8 +279,8 @@ TEST_F(ChannelTest, WaitAfterAttachRunAndShutdown) {

HandleSignalsState hss;

EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,

mp->AddWaiter(0, &waiter, MOJO_HANDLE_SIGNAL_READABLE, 123, &hss));

- EXPECT_EQ(0u, hss.satisfied_signals);

- EXPECT_EQ(0u, hss.satisfiable_signals);

+ EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfied_signals);

+ EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfiable_signals);

mp->Close(0);

« no previous file with comments | « mojo/edk/js/core.cc ('k') | mojo/edk/system/core_unittest.cc » ('j') | no next file with comments »