Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 741503002: pylint: upgrade to 1.3.1 (Closed)

Created:
6 years, 1 month ago by vapier
Modified:
6 years, 1 month ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

pylint: upgrade to 1.3.1 The current pylint is very old at this point. Pull in the latest version as it supports a lot more features. Also need to fix the pylint wrapper to actually update sys.path to use the local modules. We include the six module since not all bots have it, and it's small. This will trigger new warnings in files, but they look like legitimate issues that should be fixed at some point. BUG=chromium:431514 TEST=ran on some code bases and checked output Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292988

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17406 lines, -10011 lines) Patch
M pylintrc View 2 chunks +4 lines, -4 lines 2 comments Download
D third_party/logilab/astng/LICENSE.txt View 1 chunk +0 lines, -340 lines 0 comments Download
D third_party/logilab/astng/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/logilab/astng/__init__.py View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/logilab/astng/__pkginfo__.py View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/logilab/astng/as_string.py View 1 chunk +0 lines, -427 lines 0 comments Download
D third_party/logilab/astng/bases.py View 1 chunk +0 lines, -629 lines 0 comments Download
D third_party/logilab/astng/builder.py View 1 chunk +0 lines, -226 lines 0 comments Download
D third_party/logilab/astng/exceptions.py View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/logilab/astng/inference.py View 1 chunk +0 lines, -382 lines 0 comments Download
D third_party/logilab/astng/inspector.py View 1 chunk +0 lines, -289 lines 0 comments Download
D third_party/logilab/astng/manager.py View 1 chunk +0 lines, -299 lines 0 comments Download
D third_party/logilab/astng/mixins.py View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/logilab/astng/node_classes.py View 1 chunk +0 lines, -903 lines 0 comments Download
D third_party/logilab/astng/nodes.py View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/logilab/astng/protocols.py View 1 chunk +0 lines, -321 lines 0 comments Download
D third_party/logilab/astng/raw_building.py View 1 chunk +0 lines, -345 lines 0 comments Download
D third_party/logilab/astng/rebuilder.py View 1 chunk +0 lines, -864 lines 0 comments Download
D third_party/logilab/astng/scoped_nodes.py View 1 chunk +0 lines, -977 lines 0 comments Download
D third_party/logilab/astng/utils.py View 1 chunk +0 lines, -241 lines 0 comments Download
A third_party/logilab/astroid/LICENSE.txt View 1 chunk +340 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/README.chromium View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/__init__.py View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/__pkginfo__.py View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/as_string.py View 1 chunk +499 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/bases.py View 1 chunk +617 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/brain/py2gi.py View 1 chunk +159 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/brain/py2mechanize.py View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/brain/py2qt4.py View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/brain/py2stdlib.py View 1 chunk +331 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/builder.py View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/exceptions.py View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/inference.py View 1 chunk +400 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/inspector.py View 1 chunk +273 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/manager.py View 1 chunk +347 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/mixins.py View 1 chunk +122 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/modutils.py View 1 chunk +635 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/node_classes.py View 1 chunk +950 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/nodes.py View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/protocols.py View 1 chunk +365 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/raw_building.py View 1 chunk +361 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/rebuilder.py View 1 chunk +961 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/scoped_nodes.py View 1 chunk +1277 lines, -0 lines 0 comments Download
A third_party/logilab/astroid/utils.py View 1 chunk +238 lines, -0 lines 0 comments Download
M third_party/logilab/common/LICENSE.txt View 9 chunks +13 lines, -14 lines 0 comments Download
M third_party/logilab/common/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/logilab/common/__init__.py View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/logilab/common/__pkginfo__.py View 4 chunks +14 lines, -4 lines 0 comments Download
M third_party/logilab/common/changelog.py View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/logilab/common/clcommands.py View 6 chunks +31 lines, -29 lines 0 comments Download
M third_party/logilab/common/cli.py View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/logilab/common/compat.py View 5 chunks +6 lines, -171 lines 0 comments Download
M third_party/logilab/common/configuration.py View 36 chunks +122 lines, -85 lines 0 comments Download
M third_party/logilab/common/corbautils.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/logilab/common/daemon.py View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/logilab/common/date.py View 5 chunks +34 lines, -26 lines 0 comments Download
M third_party/logilab/common/dbf.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/logilab/common/debugger.py View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/logilab/common/decorators.py View 6 chunks +15 lines, -17 lines 0 comments Download
M third_party/logilab/common/deprecation.py View 2 chunks +149 lines, -73 lines 0 comments Download
M third_party/logilab/common/fileutils.py View 4 chunks +6 lines, -4 lines 0 comments Download
M third_party/logilab/common/graph.py View 8 chunks +25 lines, -16 lines 0 comments Download
D third_party/logilab/common/hg.py View 1 chunk +0 lines, -130 lines 0 comments Download
M third_party/logilab/common/logging_ext.py View 3 chunks +21 lines, -4 lines 0 comments Download
M third_party/logilab/common/modutils.py View 15 chunks +72 lines, -23 lines 0 comments Download
M third_party/logilab/common/optik_ext.py View 6 chunks +9 lines, -14 lines 0 comments Download
D third_party/logilab/common/pdf_ext.py View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/logilab/common/pyro_ext.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/logilab/common/pytest.py View 25 chunks +41 lines, -64 lines 0 comments Download
A third_party/logilab/common/registry.py View 1 chunk +1119 lines, -0 lines 0 comments Download
M third_party/logilab/common/shellutils.py View 12 chunks +38 lines, -19 lines 0 comments Download
M third_party/logilab/common/table.py View 8 chunks +12 lines, -6 lines 0 comments Download
M third_party/logilab/common/tasksqueue.py View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/logilab/common/testlib.py View 36 chunks +112 lines, -102 lines 0 comments Download
M third_party/logilab/common/textutils.py View 3 chunks +11 lines, -6 lines 0 comments Download
M third_party/logilab/common/umessage.py View 5 chunks +64 lines, -37 lines 0 comments Download
M third_party/logilab/common/ureports/__init__.py View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/logilab/common/ureports/docbook_writer.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/logilab/common/ureports/html_writer.py View 3 chunks +36 lines, -34 lines 0 comments Download
M third_party/logilab/common/ureports/nodes.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/logilab/common/ureports/text_writer.py View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/logilab/common/urllib2ext.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/logilab/common/visitor.py View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/pylint.py View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/pylint/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/pylint/__init__.py View 2 chunks +32 lines, -4 lines 0 comments Download
A third_party/pylint/__main__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/pylint/__pkginfo__.py View 3 chunks +24 lines, -18 lines 0 comments Download
M third_party/pylint/checkers/__init__.py View 9 chunks +27 lines, -47 lines 0 comments Download
M third_party/pylint/checkers/base.py View 26 chunks +673 lines, -290 lines 0 comments Download
M third_party/pylint/checkers/classes.py View 25 chunks +432 lines, -152 lines 0 comments Download
M third_party/pylint/checkers/design_analysis.py View 18 chunks +103 lines, -80 lines 0 comments Download
M third_party/pylint/checkers/exceptions.py View 9 chunks +161 lines, -52 lines 0 comments Download
M third_party/pylint/checkers/format.py View 9 chunks +744 lines, -161 lines 0 comments Download
M third_party/pylint/checkers/imports.py View 20 chunks +97 lines, -77 lines 0 comments Download
M third_party/pylint/checkers/logging.py View 4 chunks +114 lines, -66 lines 0 comments Download
M third_party/pylint/checkers/misc.py View 4 chunks +56 lines, -29 lines 0 comments Download
M third_party/pylint/checkers/newstyle.py View 4 chunks +73 lines, -30 lines 0 comments Download
M third_party/pylint/checkers/raw_metrics.py View 4 chunks +18 lines, -14 lines 0 comments Download
M third_party/pylint/checkers/similar.py View 15 chunks +65 lines, -34 lines 0 comments Download
A third_party/pylint/checkers/stdlib.py View 1 chunk +70 lines, -0 lines 0 comments Download
D third_party/pylint/checkers/string_format.py View 1 chunk +0 lines, -157 lines 0 comments Download
A third_party/pylint/checkers/strings.py View 1 chunk +619 lines, -0 lines 0 comments Download
M third_party/pylint/checkers/typecheck.py View 16 chunks +349 lines, -71 lines 0 comments Download
M third_party/pylint/checkers/utils.py View 16 chunks +172 lines, -67 lines 0 comments Download
M third_party/pylint/checkers/variables.py View 25 chunks +481 lines, -91 lines 0 comments Download
M third_party/pylint/config.py View 6 chunks +30 lines, -27 lines 0 comments Download
M third_party/pylint/epylint.py View 5 chunks +73 lines, -47 lines 0 comments Download
M third_party/pylint/gui.py View 20 chunks +158 lines, -97 lines 0 comments Download
M third_party/pylint/interfaces.py View 3 chunks +14 lines, -40 lines 0 comments Download
M third_party/pylint/lint.py View 37 chunks +404 lines, -292 lines 0 comments Download
M third_party/pylint/pyreverse/diadefslib.py View 11 chunks +21 lines, -19 lines 0 comments Download
M third_party/pylint/pyreverse/diagrams.py View 11 chunks +32 lines, -32 lines 0 comments Download
M third_party/pylint/pyreverse/main.py View 6 chunks +47 lines, -53 lines 0 comments Download
M third_party/pylint/pyreverse/utils.py View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/pylint/pyreverse/writer.py View 9 chunks +36 lines, -33 lines 0 comments Download
M third_party/pylint/reporters/__init__.py View 6 chunks +72 lines, -13 lines 0 comments Download
M third_party/pylint/reporters/guireporter.py View 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/pylint/reporters/html.py View 6 chunks +11 lines, -10 lines 0 comments Download
M third_party/pylint/reporters/text.py View 5 chunks +52 lines, -64 lines 0 comments Download
A third_party/pylint/testutils.py View 1 chunk +386 lines, -0 lines 0 comments Download
M third_party/pylint/utils.py View 20 chunks +481 lines, -159 lines 0 comments Download
A third_party/six/LICENSE.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/six/README.chromium View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/six/__init__.py View 1 chunk +762 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vapier
6 years, 1 month ago (2014-11-18 18:40:01 UTC) #2
M-A Ruel
Thanks, lgtm
6 years, 1 month ago (2014-11-18 18:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741503002/1
6 years, 1 month ago (2014-11-18 18:54:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=292988
6 years, 1 month ago (2014-11-18 18:58:58 UTC) #6
M-A Ruel
https://codereview.chromium.org/741503002/diff/1/pylintrc File pylintrc (left): https://codereview.chromium.org/741503002/diff/1/pylintrc#oldcode74 pylintrc:74: include-ids=yes Was it required? It feels like a regression. ...
6 years, 1 month ago (2014-11-18 20:25:06 UTC) #7
vapier
6 years, 1 month ago (2014-11-18 20:28:52 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/741503002/diff/1/pylintrc
File pylintrc (left):

https://codereview.chromium.org/741503002/diff/1/pylintrc#oldcode74
pylintrc:74: include-ids=yes
removing it was on purpose because pylint warns:
Warning: option include-ids is deprecated and ignored.

as for your issue, the thing to use is at the end of the message:
R:  1, 0: Cyclic import (telemetry.core.platform ->
telemetry.core.platform.linux_platform_backend ->
telemetry.util.support_binaries -> telemetry.util.cloud_storage) (cyclic-import)

use "cyclic-import" instead of "R###" now.

Powered by Google App Engine
This is Rietveld 408576698