Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 1296760543d9c3958ac32ac8a6ba735da6e69c78..453a7fd74a2902633e3727b22108ff2d3fd7ce5f 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -242,9 +242,8 @@ void WebViewGuest::CreateWebContents(
if (!base::IsStringUTF8(storage_partition_id)) {
content::RecordAction(
base::UserMetricsAction("BadMessageTerminate_BPGM"));
- base::KillProcess(
- owner_render_process_host->GetHandle(),
- content::RESULT_CODE_KILLED_BAD_MESSAGE, false);
+ owner_render_process_host->Shutdown(content::RESULT_CODE_KILLED_BAD_MESSAGE,
+ false);
callback.Run(NULL);
return;
}
@@ -672,7 +671,8 @@ void WebViewGuest::Terminate() {
base::ProcessHandle process_handle =
web_contents()->GetRenderProcessHost()->GetHandle();
if (process_handle)
- base::KillProcess(process_handle, content::RESULT_CODE_KILLED, false);
+ web_contents()->GetRenderProcessHost()->Shutdown(
+ content::RESULT_CODE_KILLED, false);
}
bool WebViewGuest::ClearData(const base::Time remove_since,
« no previous file with comments | « extensions/browser/guest_view/guest_view_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698