extensions/browser/guest_view/guest_view_manager.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_guest.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_manager.cc

diff --git a/extensions/browser/guest_view/guest_view_manager.cc b/extensions/browser/guest_view/guest_view_manager.cc

index 80efe79ed9bdc8598f2205b16cd779519d3e0713..17198bd0fb9384718efcc076079a528bdcba0a24 100644

--- a/extensions/browser/guest_view/guest_view_manager.cc

+++ b/extensions/browser/guest_view/guest_view_manager.cc

@@ -288,10 +288,8 @@ bool GuestViewManager::CanEmbedderAccessInstanceIDMaybeKill(

// The embedder process is trying to access a guest it does not own.

content::RecordAction(

base::UserMetricsAction("BadMessageTerminate_BPGM"));

- base::KillProcess(

- content::RenderProcessHost::FromID(embedder_render_process_id)->

- GetHandle(),

- content::RESULT_CODE_KILLED_BAD_MESSAGE, false);

+ content::RenderProcessHost::FromID(embedder_render_process_id)

+ ->Shutdown(content::RESULT_CODE_KILLED_BAD_MESSAGE, false);

return false;

}

return true;