Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index 038d8ed4e5cefe797f72a845e886f93e348c2d1f..07c4e2bf6d04477f87b129f0fd780ceb94014cac 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -240,8 +240,7 @@ void ExtensionOptionsGuest::DidNavigateMainFrame(
const content::FrameNavigateParams& params) {
if (attached() && (params.url.GetOrigin() != options_page_.GetOrigin())) {
base::RecordAction(base::UserMetricsAction("BadMessageTerminate_EOG"));
- base::KillProcess(
- web_contents()->GetRenderProcessHost()->GetHandle(),
+ web_contents()->GetRenderProcessHost()->Shutdown(
content::RESULT_CODE_KILLED_BAD_MESSAGE, false /* wait */);
}
}
« no previous file with comments | « content/public/test/mock_render_process_host.cc ('k') | extensions/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698