Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6261)

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc
diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
index 072aa4d14f926538f8e3939c7aa59e37f64ca906..9a40df84c1c27cb84de9bf816976be6a3a10dce7 100644
--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
@@ -76,8 +76,8 @@ class ExtensionCrashRecoveryTestBase : public ExtensionBrowserTest {
GetBackgroundHostForExtension(extension_id);
ASSERT_TRUE(extension_host);
- base::KillProcess(extension_host->render_process_host()->GetHandle(),
- content::RESULT_CODE_KILLED, false);
+ extension_host->render_process_host()->Shutdown(content::RESULT_CODE_KILLED,
+ false);
ASSERT_TRUE(WaitForExtensionCrash(extension_id));
ASSERT_FALSE(GetProcessManager()->
GetBackgroundHostForExtension(extension_id));
« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698