chrome/browser/extensions/window_open_apitest.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_crash_recovery_browsertest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/window_open_apitest.cc

diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc

index a626e16e30a44d610f0a7029215b1fb8f4cc517a..aa34d26972a45b89647a70403cc5eb33d91e7181 100644

--- a/chrome/browser/extensions/window_open_apitest.cc

+++ b/chrome/browser/extensions/window_open_apitest.cc

@@ -401,8 +401,8 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, ClosePanelsOnExtensionCrash) {

extensions::ProcessManager::Get(browser()->profile())

->GetBackgroundHostForExtension(extension->id());

ASSERT_TRUE(extension_host);

- base::KillProcess(extension_host->render_process_host()->GetHandle(),

- content::RESULT_CODE_KILLED, false);

+ extension_host->render_process_host()->Shutdown(content::RESULT_CODE_KILLED,

+ false);

WaitForExtensionCrash(extension->id());

// Only expect panels to close. The rest stay open to show a sad-tab.

« no previous file with comments | « chrome/browser/extensions/extension_crash_recovery_browsertest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »