Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typos Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index e27039b6013c936071b622a62f2f8edb9a0e304f..a9c1684b50ad5278a339354f43851ab62ab98afa 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -215,8 +215,7 @@ void WebViewGuest::CreateWebContents(
if (!base::IsStringUTF8(storage_partition_id)) {
content::RecordAction(
base::UserMetricsAction("BadMessageTerminate_BPGM"));
- base::KillProcess(
- embedder_render_process_host->GetHandle(),
+ embedder_render_process_host->FastShutdown(
content::RESULT_CODE_KILLED_BAD_MESSAGE, false);
callback.Run(NULL);
return;
@@ -639,7 +638,8 @@ void WebViewGuest::Terminate() {
base::ProcessHandle process_handle =
web_contents()->GetRenderProcessHost()->GetHandle();
if (process_handle)
- base::KillProcess(process_handle, content::RESULT_CODE_KILLED, false);
+ web_contents()->GetRenderProcessHost()->FastShutdown(
+ content::RESULT_CODE_KILLED, false);
}
bool WebViewGuest::ClearData(const base::Time remove_since,

Powered by Google App Engine
This is Rietveld 408576698