Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Unified Diff: content/public/browser/render_process_host.h

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typos Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index 4ae7f3a282a424a9853f82a850a46ef2b6549c53..86c7298179f5d5bcee8800fee70c557ea1b2708b 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -108,6 +108,12 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Returns True if it was able to do fast shutdown.
virtual bool FastShutdownIfPossible() = 0;
+ // Try to shutdown the associated renderer process forcedly, giving it the
+ // specified exit code. If |wait| is true, wait for the process to be actually
+ // terminated before returning.
+ // Returns True if it was able to do fast shutdown.
Charlie Reis 2014/12/01 19:44:10 nit: Don't capitalize true. Also see comment belo
Jaekyun Seok (inactive) 2014/12/02 00:50:39 Done.
+ virtual bool FastShutdown(int exit_code, bool wait) = 0;
Charlie Reis 2014/12/01 19:44:09 This doesn't really overlap with any of the FastSh
Jaekyun Seok (inactive) 2014/12/02 00:50:39 I modified FastShutdown to use ProcessDied, and so
+
// Returns true if fast shutdown was started for the renderer.
virtual bool FastShutdownStarted() const = 0;

Powered by Google App Engine
This is Rietveld 408576698