Use StopChildProcess instead of base::KillProcess to kill a renderer process

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/id_map.h"
 #include "base/process/kill.h"
@@ skipping 90 matching lines @@
   // URLRequestContextGetter's creation is moved into StoragePartition.
   // http://crbug.com/158595
   virtual StoragePartition* GetStoragePartition() const = 0;
 
   // Try to shutdown the associated renderer process as fast as possible.
   // If this renderer has any RenderViews with unload handlers, then this
   // function does nothing.  The current implementation uses TerminateProcess.
   // Returns True if it was able to do fast shutdown.
   virtual bool FastShutdownIfPossible() = 0;
 
+  // Try to shutdown the associated renderer process forcedly, giving it the
+  // specified exit code. If |wait| is true, wait for the process to be actually
+  // terminated before returning.
+  // Returns True if it was able to do fast shutdown.

[Charlie Reis, 2014/12/01 19:44:10]

nit: Don't capitalize true.  Also see comment below about "fast shutdown."

[Jaekyun Seok (inactive), 2014/12/02 00:50:39]

Done.

+  virtual bool FastShutdown(int exit_code, bool wait) = 0;

[Charlie Reis, 2014/12/01 19:44:09]

This doesn't really overlap with any of the FastShutdownIfPossible or
FastShutdownStarted logic, so I think calling it FastShutdown is confusing.

Can we call it KillProcess (or just Kill) instead?  I'd list it above
FastShutdownIfPossible since it's a more basic version.

[Jaekyun Seok (inactive), 2014/12/02 00:50:39]

I modified FastShutdown to use ProcessDied, and so I believe that the method
name is reasonable now.

+
   // Returns true if fast shutdown was started for the renderer.
   virtual bool FastShutdownStarted() const = 0;
 
   // Dump the child process' handle table before shutting down.
   virtual void DumpHandles() = 0;
 
   // Returns the process object associated with the child process.  In certain
   // tests or single-process mode, this will actually represent the current
   // process.
   //
@@ skipping 166 matching lines @@
   static void SetMaxRendererProcessCount(size_t count);
 
   // Returns the current maximum number of renderer process hosts kept by the
   // content module.
   static size_t GetMaxRendererProcessCount();
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_