Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 740673002: Do fewer encoding checks in FlatStringReader used in the JSON stringifier. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Do fewer encoding checks in FlatStringReader used in the JSON stringifier. R=ishell@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/11a621bbee0707eb730cfc30a48d3fc33cbe8b3b

Patch Set 1 #

Patch Set 2 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
6 years, 1 month ago (2014-11-19 08:21:09 UTC) #1
Igor Sheludko
lgtm
6 years, 1 month ago (2014-11-19 09:07:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740673002/1
6 years, 1 month ago (2014-11-19 09:09:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/1417)
6 years, 1 month ago (2014-11-19 09:21:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740673002/20001
6 years, 1 month ago (2014-11-19 10:46:14 UTC) #8
Michael Achenbach
Restarting tryserver... will hit the cq again afterwards.
6 years, 1 month ago (2014-11-19 10:49:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740673002/20001
6 years, 1 month ago (2014-11-19 10:50:13 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 11:16:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698