src/json-stringifier.h - Issue 740673002: Do fewer encoding checks in FlatStringReader used in the JSON stringifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 740673002: Do fewer encoding checks in FlatStringReader used in the JSON stringifier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix windows build Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index 4cdf31e45696f08f0a90c4fc31cc26948c09ff72..cbceaaead79c9c1a2f4efdc80fecae95a729089b 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -641,7 +641,7 @@ void BasicJsonStringifier::SerializeString_(Handle<String> string) {

} else {

FlatStringReader reader(isolate_, string);

for (int i = 0; i < reader.length(); i++) {

- SrcChar c = static_cast<SrcChar>(reader.Get(i));

+ SrcChar c = reader.Get<SrcChar>(i);

if (DoNotEscape(c)) {

builder_.Append<SrcChar, DestChar>(c);

} else {

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »