build/common.gypi - Issue 740663003: Re-enable globals instrumentation under ASan on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 740663003: Re-enable globals instrumentation under ASan on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 52fa8b01360a3b208eb16e89d88afc165cce030b..7a76000b9396aa775add8bd8a46af0bb42c7e0d4 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4186,13 +4186,6 @@

}],

- 'conditions': [

- ['OS=="mac"', {

- 'cflags': [

- '-mllvm -asan-globals=0', # http://crbug.com/352073

- ],

- }],

- ],

}],

['ubsan==1', {

'target_conditions': [

@@ -4921,7 +4914,6 @@

'xcode_settings': {

'OTHER_CFLAGS': [

'-fsanitize=address',

- '-mllvm -asan-globals=0', # http://crbug.com/352073

'-gline-tables-only',

« no previous file with comments | « no previous file | no next file » | no next file with comments »