Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: build/common.gypi

Issue 740663003: Re-enable globals instrumentation under ASan on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4168 matching lines...) Expand 10 before | Expand all | Expand 10 after
4179 'cflags': [ 4179 'cflags': [
4180 '-fsanitize=address', 4180 '-fsanitize=address',
4181 # TODO(earthdok): Re-enable. http://crbug.com/427202 4181 # TODO(earthdok): Re-enable. http://crbug.com/427202
4182 #'-fsanitize-blacklist=<(asan_blacklist)', 4182 #'-fsanitize-blacklist=<(asan_blacklist)',
4183 ], 4183 ],
4184 'ldflags': [ 4184 'ldflags': [
4185 '-fsanitize=address', 4185 '-fsanitize=address',
4186 ], 4186 ],
4187 }], 4187 }],
4188 ], 4188 ],
4189 'conditions': [
4190 ['OS=="mac"', {
4191 'cflags': [
4192 '-mllvm -asan-globals=0', # http://crbug.com/352073
4193 ],
4194 }],
4195 ],
4196 }], 4189 }],
4197 ['ubsan==1', { 4190 ['ubsan==1', {
4198 'target_conditions': [ 4191 'target_conditions': [
4199 ['_toolset=="target"', { 4192 ['_toolset=="target"', {
4200 'cflags': [ 4193 'cflags': [
4201 '-fsanitize=undefined', 4194 '-fsanitize=undefined',
4202 # -fsanitize=vptr is incompatible with -fno-rtti. 4195 # -fsanitize=vptr is incompatible with -fno-rtti.
4203 '-fno-sanitize=vptr', 4196 '-fno-sanitize=vptr',
4204 # Employ the experimental PBQP register allocator to avoid 4197 # Employ the experimental PBQP register allocator to avoid
4205 # slow compilation on files with too many basic blocks. 4198 # slow compilation on files with too many basic blocks.
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
4914 'conditions': [ 4907 'conditions': [
4915 ['clang==1', { 4908 ['clang==1', {
4916 'variables': { 4909 'variables': {
4917 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin', 4910 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
4918 }, 4911 },
4919 }], 4912 }],
4920 ['asan==1', { 4913 ['asan==1', {
4921 'xcode_settings': { 4914 'xcode_settings': {
4922 'OTHER_CFLAGS': [ 4915 'OTHER_CFLAGS': [
4923 '-fsanitize=address', 4916 '-fsanitize=address',
4924 '-mllvm -asan-globals=0', # http://crbug.com/352073
4925 '-gline-tables-only', 4917 '-gline-tables-only',
4926 ], 4918 ],
4927 }, 4919 },
4928 }], 4920 }],
4929 ['asan_coverage!=0', { 4921 ['asan_coverage!=0', {
4930 'target_conditions': [ 4922 'target_conditions': [
4931 ['_toolset=="target"', { 4923 ['_toolset=="target"', {
4932 'cflags': [ 4924 'cflags': [
4933 '-mllvm -asan-coverage=<(asan_coverage)', 4925 '-mllvm -asan-coverage=<(asan_coverage)',
4934 ], 4926 ],
(...skipping 924 matching lines...) Expand 10 before | Expand all | Expand 10 after
5859 # settings in target dicts. SYMROOT is a special case, because many other 5851 # settings in target dicts. SYMROOT is a special case, because many other
5860 # Xcode variables depend on it, including variables such as 5852 # Xcode variables depend on it, including variables such as
5861 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5853 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5862 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5854 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5863 # files to appear (when present) in the UI as actual files and not red 5855 # files to appear (when present) in the UI as actual files and not red
5864 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5856 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5865 # and therefore SYMROOT, needs to be set at the project level. 5857 # and therefore SYMROOT, needs to be set at the project level.
5866 'SYMROOT': '<(DEPTH)/xcodebuild', 5858 'SYMROOT': '<(DEPTH)/xcodebuild',
5867 }, 5859 },
5868 } 5860 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698