Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 740663003: Re-enable globals instrumentation under ASan on Mac. (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
Reviewers:
earthdok
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable globals instrumentation under ASan on Mac. The corresponding bug in ASan has been fixed in March 2014. BUG=352073 TBR=earthdok@chromium.org Committed: https://crrev.com/964445e21b60278ff6e0de560c4110d8a161be36 Cr-Commit-Position: refs/heads/master@{#307253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Alexander Potapenko
For the record, the UAF in PinchViewportTest.TestMainFrameInitializationSizing is unrelated and is also reported in: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_asan_64/builds/178 ...
6 years ago (2014-12-08 12:16:09 UTC) #1
earthdok
On 2014/12/08 12:16:09, Alexander Potapenko wrote: > For the record, the UAF in PinchViewportTest.TestMainFrameInitializationSizing > ...
6 years ago (2014-12-08 13:43:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740663003/1
6 years ago (2014-12-08 14:48:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 15:48:45 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-08 15:50:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/964445e21b60278ff6e0de560c4110d8a161be36
Cr-Commit-Position: refs/heads/master@{#307253}

Powered by Google App Engine
This is Rietveld 408576698