Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: media/base/pipeline_unittest.cc

Issue 740663002: Relanding 'Ignore seek operations to the current time in pause state' patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplified GetMediaTime() as per review Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index 9528cf7b3b4bb40e800ffcd4ff2eb5d6eed6569b..ddc73095cb61edf29a89e8e57215d6d28dfd2b00 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -619,6 +619,9 @@ TEST_F(PipelineTest, EndedCallback) {
message_loop_.RunUntilIdle();
EXPECT_CALL(callbacks_, OnEnded());
+ // There are cases where duration is reported wrong initially, so there is
DaleCurtis 2014/12/02 18:14:05 Hmm, doesn't this add a bunch of log spam / error
Srirama 2014/12/03 14:43:02 I thought about it initially but after seeing the
DaleCurtis 2014/12/04 02:04:41 If there's just a few tests which trigger this OnD
Srirama 2014/12/04 03:16:46 will check it.
+ // an onDurationChange event fired again on OnEnded event if required.
DaleCurtis 2014/12/02 18:14:05 s/onDuration/OnDuration/
Srirama 2014/12/03 14:43:02 Done.
+ EXPECT_CALL(callbacks_, OnDurationChange());
text_stream()->SendEosNotification();
message_loop_.RunUntilIdle();
}

Powered by Google App Engine
This is Rietveld 408576698