Relanding 'Ignore seek operations to the current time in pause state' patch

media/base/pipeline_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/test/simple_test_tick_clock.h"
@@ skipping 601 matching lines @@
   SetRendererExpectations();
   StartPipelineAndExpect(PIPELINE_OK);
 
   AddTextStream();
 
   // The ended callback shouldn't run until all renderers have ended.
   ended_cb_.Run();
   message_loop_.RunUntilIdle();
 
   EXPECT_CALL(callbacks_, OnEnded());
+  // There are cases where duration is reported wrong initially, so there is

[DaleCurtis, 2014/12/02 18:14:05]

Hmm, doesn't this add a  bunch of log spam / errors in some cases where it
doesn't get triggered?

[Srirama, 2014/12/03 14:43:02]

I thought about it initially but after seeing the local unittest results and bot
results i thought it is ok. I don't know if i can do it conditionally similar to
what i am doing in RunEndedCallbackIfNeeded(). What do you suggest?

[DaleCurtis, 2014/12/04 02:04:41]

If there's just a few tests which trigger this OnDuration change you should
explicitly add it to those tests. If there's a bunch (> 5) you can consider
switching to a NiceMock; though we'll want to hunt down what the real issue is
here.

[Srirama, 2014/12/04 03:16:46]

will check it.

+  // an onDurationChange event fired again on OnEnded event if required.

[DaleCurtis, 2014/12/02 18:14:05]

s/onDuration/OnDuration/

[Srirama, 2014/12/03 14:43:02]

Done.

+  EXPECT_CALL(callbacks_, OnDurationChange());
   text_stream()->SendEosNotification();
   message_loop_.RunUntilIdle();
 }
 
 TEST_F(PipelineTest, ErrorDuringSeek) {
   CreateAudioStream();
   MockDemuxerStreamVector streams;
   streams.push_back(audio_stream());
 
   SetDemuxerExpectations(&streams);
@@ skipping 361 matching lines @@
 
 INSTANTIATE_TEARDOWN_TEST(Error, InitDemuxer);
 INSTANTIATE_TEARDOWN_TEST(Error, InitRenderer);
 INSTANTIATE_TEARDOWN_TEST(Error, Flushing);
 INSTANTIATE_TEARDOWN_TEST(Error, Seeking);
 INSTANTIATE_TEARDOWN_TEST(Error, Playing);
 
 INSTANTIATE_TEARDOWN_TEST(ErrorAndStop, Playing);
 
 }  // namespace media