Relanding 'Ignore seek operations to the current time in pause state' patch

media/base/pipeline.cc

Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index 059710525372976dad8118a21e144fc6542d154c..989eb8f0adba3c08ea3625daf54c5c9b4812bc62 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -634,6 +634,11 @@ void Pipeline::RunEndedCallbackIfNeeded() {
   if (text_renderer_ && text_renderer_->HasTracks() && !text_renderer_ended_)
     return;
 
+  // Correct the duration if current time is less
+  TimeDelta media_time = renderer_->GetMediaTime();
+  if (media_time < duration_) {
+    duration_ = media_time;

[philipj_slow, 2014/11/25 10:01:04]

Shouldn't this be SetDuration(media_time), or what will end up invoking
duration_change_cb_?

[Srirama, 2014/11/25 10:19:29]

I have done a similar thing in patchset4, but there are many failures as the
duration change callback is invoked twice where as it is expected only once. So
do we need to fix those failures or directly calling SetDuration() will not
result in those failures?

I created patchset5 by removing callback for testing to see the results in all
the bots.

[philipj_slow, 2014/11/25 12:24:29]

By only setting duration_, I guess HTMLMediaElement.duration will change without
a durationchange event being fired? That's not OK, so I think updating tests to
deal with the new durationchange event is the only way to go. Of course this
change may have introduced real bugs, so check carefully :)

+  }
   DCHECK_EQ(status_, PIPELINE_OK);
   ended_cb_.Run();
 }