Relanding 'Ignore seek operations to the current time in pause state' patch

media/base/pipeline.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/pipeline.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 616 matching lines @@
 
 void Pipeline::RunEndedCallbackIfNeeded() {
   DCHECK(task_runner_->BelongsToCurrentThread());
 
   if (renderer_ && !renderer_ended_)
     return;
 
   if (text_renderer_ && text_renderer_->HasTracks() && !text_renderer_ended_)
     return;
 
+  // Correct the duration if current time is less
+  TimeDelta media_time = renderer_->GetMediaTime();
+  if (media_time < duration_) {
+    duration_ = media_time;

[philipj_slow, 2014/11/25 10:01:04]

Shouldn't this be SetDuration(media_time), or what will end up invoking
duration_change_cb_?

[Srirama, 2014/11/25 10:19:29]

I have done a similar thing in patchset4, but there are many failures as the
duration change callback is invoked twice where as it is expected only once. So
do we need to fix those failures or directly calling SetDuration() will not
result in those failures?

I created patchset5 by removing callback for testing to see the results in all
the bots.

[philipj_slow, 2014/11/25 12:24:29]

By only setting duration_, I guess HTMLMediaElement.duration will change without
a durationchange event being fired? That's not OK, so I think updating tests to
deal with the new durationchange event is the only way to go. Of course this
change may have introduced real bugs, so check carefully :)

+  }
   DCHECK_EQ(status_, PIPELINE_OK);
   ended_cb_.Run();
 }
 
 scoped_ptr<TextRenderer> Pipeline::CreateTextRenderer() {
   DCHECK(task_runner_->BelongsToCurrentThread());
 
   const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
   if (!cmd_line->HasSwitch(switches::kEnableInbandTextTracks))
     return scoped_ptr<media::TextRenderer>();
@@ skipping 66 matching lines @@
   metadata_cb_.Run(metadata);
 }
 
 void Pipeline::BufferingStateChanged(BufferingState new_buffering_state) {
   DVLOG(1) << __FUNCTION__ << "(" << new_buffering_state << ") ";
   DCHECK(task_runner_->BelongsToCurrentThread());
   buffering_state_cb_.Run(new_buffering_state);
 }
 
 }  // namespace media