Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 740453004: IDL: Basic dictionary inheritance support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestDictionary.cpp
diff --git a/Source/bindings/tests/results/core/V8TestDictionary.cpp b/Source/bindings/tests/results/core/V8TestDictionary.cpp
index 324c3351ccbd2ff1b2f577deb677a2dfb983a6a6..dd8554956cc0946640db468cb862dc8082c5ba86 100644
--- a/Source/bindings/tests/results/core/V8TestDictionary.cpp
+++ b/Source/bindings/tests/results/core/V8TestDictionary.cpp
@@ -194,89 +194,94 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Valu
v8::Handle<v8::Value> toV8(TestDictionary& impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
+ toV8TestDictionary(impl, v8Object, creationContext, isolate);
+ return v8Object;
+}
+
+void toV8TestDictionary(TestDictionary& impl, v8::Handle<v8::Object> dest, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
if (impl.hasBooleanMember()) {
- v8Object->Set(v8String(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isolate));
+ dest->Set(v8String(isolate, "booleanMember"), v8Boolean(impl.booleanMember(), isolate));
}
if (impl.hasCreateMember()) {
- v8Object->Set(v8String(isolate, "create"), v8Boolean(impl.createMember(), isolate));
+ dest->Set(v8String(isolate, "create"), v8Boolean(impl.createMember(), isolate));
}
if (impl.hasDoubleOrNullMember()) {
- v8Object->Set(v8String(isolate, "doubleOrNullMember"), v8::Number::New(isolate, impl.doubleOrNullMember()));
+ dest->Set(v8String(isolate, "doubleOrNullMember"), v8::Number::New(isolate, impl.doubleOrNullMember()));
} else {
- v8Object->Set(v8String(isolate, "doubleOrNullMember"), v8::Null(isolate));
+ dest->Set(v8String(isolate, "doubleOrNullMember"), v8::Null(isolate));
}
if (impl.hasElementOrNullMember()) {
- v8Object->Set(v8String(isolate, "elementOrNullMember"), toV8(impl.elementOrNullMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "elementOrNullMember"), toV8(impl.elementOrNullMember(), creationContext, isolate));
}
if (impl.hasEnumMember()) {
- v8Object->Set(v8String(isolate, "enumMember"), v8String(isolate, impl.enumMember()));
+ dest->Set(v8String(isolate, "enumMember"), v8String(isolate, impl.enumMember()));
} else {
- v8Object->Set(v8String(isolate, "enumMember"), v8String(isolate, String("foo")));
+ dest->Set(v8String(isolate, "enumMember"), v8String(isolate, String("foo")));
}
if (impl.hasLongMember()) {
- v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, impl.longMember()));
+ dest->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, impl.longMember()));
} else {
- v8Object->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, 1));
+ dest->Set(v8String(isolate, "longMember"), v8::Integer::New(isolate, 1));
}
if (impl.hasObjectMember()) {
ASSERT(impl.objectMember().isObject());
- v8Object->Set(v8String(isolate, "objectMember"), impl.objectMember().v8Value());
+ dest->Set(v8String(isolate, "objectMember"), impl.objectMember().v8Value());
}
if (impl.hasObjectOrNullMember()) {
ASSERT(impl.objectOrNullMember().isObject());
- v8Object->Set(v8String(isolate, "objectOrNullMember"), impl.objectOrNullMember().v8Value());
+ dest->Set(v8String(isolate, "objectOrNullMember"), impl.objectOrNullMember().v8Value());
}
if (impl.hasStringArrayMember()) {
- v8Object->Set(v8String(isolate, "stringArrayMember"), v8Array(impl.stringArrayMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "stringArrayMember"), v8Array(impl.stringArrayMember(), creationContext, isolate));
}
if (impl.hasStringMember()) {
- v8Object->Set(v8String(isolate, "stringMember"), v8String(isolate, impl.stringMember()));
+ dest->Set(v8String(isolate, "stringMember"), v8String(isolate, impl.stringMember()));
}
if (impl.hasStringOrNullMember()) {
- v8Object->Set(v8String(isolate, "stringOrNullMember"), v8String(isolate, impl.stringOrNullMember()));
+ dest->Set(v8String(isolate, "stringOrNullMember"), v8String(isolate, impl.stringOrNullMember()));
} else {
- v8Object->Set(v8String(isolate, "stringOrNullMember"), v8String(isolate, String("default string value")));
+ dest->Set(v8String(isolate, "stringOrNullMember"), v8String(isolate, String("default string value")));
}
if (impl.hasStringSequenceMember()) {
- v8Object->Set(v8String(isolate, "stringSequenceMember"), v8Array(impl.stringSequenceMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "stringSequenceMember"), v8Array(impl.stringSequenceMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceGarbageCollectedMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceGarbageCollectedMember"), toV8(impl.testInterfaceGarbageCollectedMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceGarbageCollectedMember"), toV8(impl.testInterfaceGarbageCollectedMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceGarbageCollectedOrNullMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceGarbageCollectedOrNullMember"), toV8(impl.testInterfaceGarbageCollectedOrNullMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceGarbageCollectedOrNullMember"), toV8(impl.testInterfaceGarbageCollectedOrNullMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceMember"), toV8(impl.testInterfaceMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceMember"), toV8(impl.testInterfaceMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceOrNullMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceOrNullMember"), toV8(impl.testInterfaceOrNullMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceOrNullMember"), toV8(impl.testInterfaceOrNullMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceWillBeGarbageCollectedMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedMember"), toV8(impl.testInterfaceWillBeGarbageCollectedMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedMember"), toV8(impl.testInterfaceWillBeGarbageCollectedMember(), creationContext, isolate));
}
if (impl.hasTestInterfaceWillBeGarbageCollectedOrNullMember()) {
- v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedOrNullMember"), toV8(impl.testInterfaceWillBeGarbageCollectedOrNullMember(), creationContext, isolate));
+ dest->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedOrNullMember"), toV8(impl.testInterfaceWillBeGarbageCollectedOrNullMember(), creationContext, isolate));
}
- return v8Object;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698